WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
270 stars 3 forks source link

Does not work on MAC having php 7.0.21 #201

Open postmagthemes opened 4 years ago

postmagthemes commented 4 years ago

I am using Mac having php version 7.0.21 and wp 5.4.1 . But i never success to run theme sniffer. it does not give any report. Why is that.

dingo-d commented 4 years ago

You'll need to add some more details. Is there any debug log or console screenshot so that we can see why it's not working?

postmagthemes commented 4 years ago

Here is the screens shot. It is same in the server also having php 7.3.16 . No output.

On May 29, 2020, at 2:01 PM, Denis Žoljom notifications@github.com wrote:

You'll need to add some more details. Is there any debug log or console screenshot so that we can see why it's not working?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WPTRT/theme-sniffer/issues/201#issuecomment-635839695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFE6XYXVEA5SZKHC4MY3W3RT5VONANCNFSM4NNWF3RQ.

dingo-d commented 4 years ago

You didn't attach any screenshot 🙈

postmagthemes commented 4 years ago

Yes it is there , I am still doing

On May 29, 2020, at 2:55 PM, Denis Žoljom notifications@github.com wrote:

You didn't attach any screenshot 🙈

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WPTRT/theme-sniffer/issues/201#issuecomment-635864634, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFE6X3ZQ7PMLNNBBKHQ4MLRT53WRANCNFSM4NNWF3RQ.

dingo-d commented 4 years ago

Screenshot 2020-05-29 at 12 29 54

You are answering from email. You cannot attach images on GH issues from email...

postmagthemes commented 4 years ago

Here are the log I got from Mac

https://prnt.sc/sq3o2k https://prnt.sc/sq3o2k

Above is the screenshot

On May 29, 2020, at 4:15 PM, Denis Žoljom notifications@github.com wrote:

https://user-images.githubusercontent.com/8638515/83250260-237a0b80-a1a8-11ea-9098-f2a0c71a48ba.png You are answering from email. You cannot attach images on GH issues from email...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WPTRT/theme-sniffer/issues/201#issuecomment-635900058, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFE6X2UMVXBWMZWEOK4GZDRT6FFLANCNFSM4NNWF3RQ.

dingo-d commented 4 years ago

Do you have errors when debug mode is enabled? Are there any errors in the browser dev console? It could be that it got to the minified JS file (looks like this is the older version that checks the JS) and it ran out of memory (sniffer cannot process minified files).

postmagthemes commented 4 years ago

Debug mode is enable but there is no error.

But in console there are 4 error those are followings.

1 Failed to load resource: the server responded with a status of 400 (Bad Request) /zerodata/wp-admin/admin-ajax.php:

2 Failed to load resource: the server responded with a status of 500 (Internal Server Error) themeSniffer-f7cbb09e8557a5ea63b2.js?ver=5.4.1:8

  1. Uncaught Error: Error: Internal Server Error: [object Object] error at Object. (themeSniffer-f7cbb09e8557a5ea63b2.js?ver=5.4.1:8) at Object. (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.4.1:2) at i (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.4.1:2) at Object.fireWith [as rejectWith] (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.4.1:2) at x (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.4.1:4) at XMLHttpRequest.c (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate,utils&ver=5.4.1:4)

Wp-config.php is as follows

define('WP_DEBUG', true); define('FS_METHOD','direct');

define('IMPORT_DEBUG', true); define('WP_MEMORY_LIMIT','556M'); define('MAX_EXECUTION_TIME','700'); define('POST_MAX_SIZE','912M'); define('UPLOAD_MAX_FILESIZE','556M'); define('MAX_INPUT_TIME','600');

Pls advice again.

rg

Postmagthemes

On May 30, 2020, at 7:13 PM, Denis Žoljom notifications@github.com wrote:

Do you have errors when debug mode is enabled? Are there any errors in the browser dev console? It could be that it got to the minified JS file (looks like this is the older version that checks the JS) and it ran out of memory (sniffer cannot process minified files).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WPTRT/theme-sniffer/issues/201#issuecomment-636330982, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFE6XYNOR2DFDJKA4X7H7LRUECWXANCNFSM4NNWF3RQ.

dingo-d commented 4 years ago

Try running it, but check the sniff only PHP files and it should work. Otherwise try using the latest release: https://github.com/WPTRT/theme-sniffer/releases/download/1.1.2/theme-sniffer.zip

postmagthemes commented 4 years ago

Now I used new version 1.1.2.

There is no option to select only php files. But it was there in oder version but same result. No success . I tried in server as well same result. I think if this below console error is sort out then it may works

Uncaught Error: Error: : [object Object] error at Object. (themeSniffer-f7cbb09e8557a5ea63b2.js?ver=5.2.6:8) at Object. (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:2) at i (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:2) at Object.fireWith [as rejectWith] (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:2) at x (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:4) at XMLHttpRequest.c (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:4)

Thanks rg

Postmagthemes

On May 31, 2020, at 12:20 PM, Denis Žoljom notifications@github.com wrote:

Try running it, but check the sniff only PHP files and it should work. Otherwise try using the latest release: https://github.com/WPTRT/theme-sniffer/releases/download/1.1.2/theme-sniffer.zip https://github.com/WPTRT/theme-sniffer/releases/download/1.1.2/theme-sniffer.zip — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WPTRT/theme-sniffer/issues/201#issuecomment-636430023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFE6X5IKDPO7M57G455GA3RUH3E5ANCNFSM4NNWF3RQ.

postmagthemes commented 4 years ago

In version 1.1.0, there is option for only PHP files. I used that then in this condition it works but no single error and single warning. It means it still does not work.

On May 31, 2020, at 12:32 PM, simon shrestha support@postmagthemes.com wrote:

Now I used new version 1.1.2.

There is no option to select only php files. But it was there in oder version but same result. No success . I tried in server as well same result. I think if this below console error is sort out then it may works

Uncaught Error: Error: : [object Object] error at Object. (themeSniffer-f7cbb09e8557a5ea63b2.js?ver=5.2.6:8) at Object. (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:2) at i (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:2) at Object.fireWith [as rejectWith] (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:2) at x (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:4) at XMLHttpRequest.c (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=5.2.6:4)

Thanks rg

Postmagthemes

On May 31, 2020, at 12:20 PM, Denis Žoljom <notifications@github.com mailto:notifications@github.com> wrote:

Try running it, but check the sniff only PHP files and it should work. Otherwise try using the latest release: https://github.com/WPTRT/theme-sniffer/releases/download/1.1.2/theme-sniffer.zip https://github.com/WPTRT/theme-sniffer/releases/download/1.1.2/theme-sniffer.zip — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WPTRT/theme-sniffer/issues/201#issuecomment-636430023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFE6X5IKDPO7M57G455GA3RUH3E5ANCNFSM4NNWF3RQ.

dingo-d commented 4 years ago

To me, it looks like out of memory issue that happens when you have some huge file that phpcs will try to tokenize and fail.

There was a case where there was a theme that had tests inside with WooCommerce mocks that had over 30k lines of code. This chocked the phpcs and caused it to fail. So my guess is that you must have some kind of file that is just too big for phpcs to tokenize properly, which causes PHP out of memory issues.

Do you have a repo that I could check to see what is happening?