search

WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
268 stars 3 forks source link

Include package-lock.json file #68

Closed dingo-d closed 6 years ago

dingo-d commented 7 years ago

When you build the plugin with new node (ver 8), package-lock.json file is created.

We should either include this in the repo, or put it in the .gitignore file.

grappler commented 7 years ago

I would include it like we do with composer.

dingo-d commented 6 years ago

Both are added with the new version :)

joyously commented 6 years ago

Does this apply? https://netweb.blog/2018/01/26/lockfiles-breaks-semantic-versioning/

dingo-d commented 6 years ago

Hmmm interesting read. I can add an update command that will run npm-check-updates command prior to any release. This will ensure that all the packages are up to date. Plus we do test the plugin before release and would notice if anything is breaking. Plus we are essentially creating an app. We're not putting theme sniffer plugin on packagist to be used via composer, or on npm repository to be used with npm/yarn.