Closed dingo-d closed 6 years ago
@grappler @ernilambar did you have the time to look at the PR? I would like to start with namespacing the plugin, and maybe adding some unit tests if necessary.
@dingo-d Sorry for the delay. Thank you for working on this.
A couple a of comments and requests
ajaxStopped
text to the progress bar?@grappler Hi I made the changes you requested, should be better now. I made it so that when you switch the theme the checking will stop. Seems like ok behavior to me.
@grappler I fixed all the collisions, I should I try to clean the commit history with interactive rebase?
Thanks! I'll get on with other work asap!
Ok so this is quite a big rewrite. In the light of core ticket #40894 I wanted to rewrite the plugin using webpack and more modern ES6 syntax of JS. Plus I wanted to separate business from presentational logic.
It is quite a bit away from your old plain jQuery, but I think that it's understandable enough and that it can encourage others in the WordPress community to start working with modern JS tools :)
I've made several modifications:
package.json
with additional information, and dependenciesPOST
toGET
requests in the callbacks, since we are not writing anything to the database - it's semantically more correctTo do: