WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
268 stars 3 forks source link

Feature/rewrite plugin webpack #79

Closed dingo-d closed 6 years ago

dingo-d commented 7 years ago

Ok so this is quite a big rewrite. In the light of core ticket #40894 I wanted to rewrite the plugin using webpack and more modern ES6 syntax of JS. Plus I wanted to separate business from presentational logic.

It is quite a bit away from your old plain jQuery, but I think that it's understandable enough and that it can encourage others in the WordPress community to start working with modern JS tools :)

I've made several modifications:

To do:

dingo-d commented 6 years ago

@grappler @ernilambar did you have the time to look at the PR? I would like to start with namespacing the plugin, and maybe adding some unit tests if necessary.

grappler commented 6 years ago

@dingo-d Sorry for the delay. Thank you for working on this.

A couple a of comments and requests

dingo-d commented 6 years ago

@grappler Hi I made the changes you requested, should be better now. I made it so that when you switch the theme the checking will stop. Seems like ok behavior to me.

dingo-d commented 6 years ago

@grappler I fixed all the collisions, I should I try to clean the commit history with interactive rebase?

dingo-d commented 6 years ago

Thanks! I'll get on with other work asap!