Feature/use namespace

[dingo-d]

The aim is to have a modern, clear-cut development process that will help with future development of the plugin.

Note

I have closed the old PR because I want everything to be handled from this repo, and not my fork (easier to maintain).

Added

• [x] Namespaces
• [x] Class autoloading
• [x] Build scripts
• [x] Updated dependencies in the packages
• [x] Rewrote the dev plugin structure

To do

• [x] Link to theme sniffer page in the plugins page is not showing
• [x] Increase the sniff speed - limit sniffing to php files and use eslint and stylelint for .js and .css files respectively
• [x] Rewrite the HTML and CSS part so that BEM methodology is used
• [x] Test the basic functionality
• [x] Find out how to zip the plugin so that it works in the build script
• [ ] Once approved, rebase and merge to master branch
• [x] Add a check for PHP files only
• [x] Pull tags from https://api.wordpress.org/themes/info/1.1/?action=feature_list and put them in a transient (pull every X days)

Review is welcomed as are suggestions.

Help from testers

From Danny Cooper:

• [x] If no 'Standard' is selected, it still looks like it's working and you have to press stop. Might be better to not start at all if no boxes are checked?
• [x] If you type into 'Theme prefixes' and press return, it refreshes the page. It would be more intuitive if it did nothing or started the sniffs.
• [x] If a theme prefix has dashes e.g 'editor-blocks' it expects variables to be $editor-blocks_variable and won't accept $editor_blocks_variable.
• [x] Can't detect the licenses here for some reason - https://github.com/editorblocks/editor-blocks-theme/blob/bc5487ad0a4e6c08c85db86cf7b2732cf4f54e37/style.css#L1-L16

From Liton Arefin:

Getting error while activation.

Parse error: syntax error, unexpected ‘:’, expecting ‘;’ or ‘{‘ in “/theme-sniffer/src/class-plugin.php” on line 153

This is fixed.

From metallicarosetail (via slack)

Error while activation on PHP 7.0.12

Fatal error: Uncaught TypeError: Return value of Theme_Sniffer\Assets\Assets_Handler::add() must be an instance of Theme_Sniffer\Assets\void, none returned in /Applications/MAMP/htdocs/review/wp-content/plugins/theme-sniffer/src/assets/class-assets-handler.php:35 Stack trace: #0 /Applications/MAMP/htdocs/review/wp-content/plugins/theme-sniffer/src/assets/assets-awareness-trait.php(41): Theme_Sniffer\Assets\Assets_Handler->add(Object(Theme_Sniffer\Assets\Script_Asset)) #1 /Applications/MAMP/htdocs/review/wp-content/plugins/theme-sniffer/src/admin-menus/class-base-admin-menu.php(33): Theme_Sniffer\Admin_Menus\Base_Admin_Menu->register_assets() #2 /Applications/MAMP/htdocs/review/wp-content/plugins/theme-sniffer/src/class-plugin.php(137): Theme_Sniffer\Admin_Menus\Base_Admin_Menu->register() #3 [internal function]: Theme_Sniffer\Core\Plugin->Theme_Sniffer\Core{closure}(Object(Theme_Sniffer\Admin_Menus\Sniff_Page), 2) #4 /Applications/MAMP/htdocs/review/wp-content/plugins/theme-sniffer/src/class-plugin.php(138): array_walk(A in /Applications/MAMP/htdocs/review/wp-content/plugins/theme-sniffer/src/assets/class-assets-handler.php on line 35

This is fixed. Removed void return types

[dingo-d]

@Danny-Cooper regarding the two issues you mentioned, the issue with the prefix, shouldn't they be named with underscore? editor_blocks?

The second issue with the licenses I don't think the reported is an error, since it detected that the license is present and that's ok. I could add a check for a type of license, but I can leave that for later.

What did work was the issue that you have theme in your theme name, and that's not allowed 🙂

Thanks for your contributions btw 🙂

[DannyCooper]

@dingo-d I was using the underscore, but the sniffer seemed to want a hyphen?

If a theme name has dashes e.g 'editor-blocks' it expects variables to be $editor-blocks_variable and won't accept $editor_blocks_variable.

[dingo-d]

@DannyCooper can you check the thing with the theme prefix? When I tried with editor_blocks I got some errors like

Variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$comments_number".

If I add editor-blocks as a prefix I get

WARNING  The "editor-blocks" prefix is not a valid namespace/function/class/variable/constant prefix in PHP.

[joyously]

You can't have a prefix with a dash. PHP will parse it as a subtraction.