WSDOT / HATS

Highway Activity Tracking System Issue Tracker
6 stars 0 forks source link

HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time #1368

Closed joeschmit closed 4 years ago

joeschmit commented 4 years ago

Other Activities without the end date/time flag set to true...

On edit requires an "End Date" to submit.

On add does not.

Screenshot 2019-10-02 10 44 20
joeschmit commented 4 years ago

bump...

jhudsonWA commented 4 years ago

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.gov | 360.705.7778


From: Joe Schmit notifications@github.com Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov; Assign assign@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

brianblood commented 4 years ago

Yep, already on it.

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joshua Hudson notifications@github.com Sent: Wednesday, October 9, 2019 9:26 AM To: WSDOT/HATS HATS@noreply.github.com Cc: Blood, Brian BloodB@wsdot.wa.gov; Assign assign@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.gov | 360.705.7778


From: Joe Schmit notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com> Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZB7CFA3A3EKQLUGY53QNYAXZA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYPDNQ#issuecomment-540078518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZDV3LOYXIQBPRYREH3QNYAXZANCNFSM4I4ZNZVA.

brianblood commented 4 years ago

Hey Josh/Joe Any insight on this bit of code when editing an Other Activity?

//Snow and Ice Records Are "Special" if (vm.FeatureTypeName.ToLower() == "snow and ice") { vm.ShowTimeRange = true; vm.ShowAvlTrucks = true; vm.HideLocationIndicator = true; }

This is not happening when creating a new record. I can either remove this bit from Edit, or add it to Add. Preferences?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joshua Hudson notifications@github.com Sent: Wednesday, October 9, 2019 9:26 AM To: WSDOT/HATS HATS@noreply.github.com Cc: Blood, Brian BloodB@wsdot.wa.gov; Assign assign@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.gov | 360.705.7778


From: Joe Schmit notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com> Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZB7CFA3A3EKQLUGY53QNYAXZA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYPDNQ#issuecomment-540078518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZDV3LOYXIQBPRYREH3QNYAXZANCNFSM4I4ZNZVA.

joeschmit commented 4 years ago

vm.ShowTimeRange = true; shouldn’t that be deprecated? We now have a flag in admin > feature activities > end date/time?

On Oct 9, 2019, at 11:31 AM, brianblood notifications@github.com<mailto:notifications@github.com> wrote:

Hey Josh/Joe Any insight on this bit of code when editing an Other Activity?

//Snow and Ice Records Are "Special" if (vm.FeatureTypeName.ToLower() == "snow and ice") { vm.ShowTimeRange = true; vm.ShowAvlTrucks = true; vm.HideLocationIndicator = true; }

This is not happening when creating a new record. I can either remove this bit from Edit, or add it to Add. Preferences?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joshua Hudson notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:26 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com> Cc: Blood, Brian BloodB@wsdot.wa.gov<mailto:BloodB@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.gov | 360.705.7778


From: Joe Schmit notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.commailto:HATS@noreply.github.com> Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.govmailto:HudsonJ@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.commailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZB7CFA3A3EKQLUGY53QNYAXZA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYPDNQ#issuecomment-540078518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZDV3LOYXIQBPRYREH3QNYAXZANCNFSM4I4ZNZVA.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT75OY7KKABNVBGJV4DQNYPOVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY3XRA#issuecomment-540130244, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT4CXNKFJF2DTRMA2HTQNYPOVANCNFSM4I4ZNZVA.

joeschmit commented 4 years ago

Not deprecated but redundant more or less, that would apply to highLocationIndicator

On Oct 9, 2019, at 11:36 AM, Joe Schmit notifications@github.com<mailto:notifications@github.com> wrote:

vm.ShowTimeRange = true; shouldn’t that be deprecated? We now have a flag in admin > feature activities > end date/time?

On Oct 9, 2019, at 11:31 AM, brianblood notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:

Hey Josh/Joe Any insight on this bit of code when editing an Other Activity?

//Snow and Ice Records Are "Special" if (vm.FeatureTypeName.ToLower() == "snow and ice") { vm.ShowTimeRange = true; vm.ShowAvlTrucks = true; vm.HideLocationIndicator = true; }

This is not happening when creating a new record. I can either remove this bit from Edit, or add it to Add. Preferences?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joshua Hudson notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:26 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.commailto:HATS@noreply.github.com> Cc: Blood, Brian BloodB@wsdot.wa.gov<mailto:BloodB@wsdot.wa.govmailto:BloodB@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.commailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.gov | 360.705.7778


From: Joe Schmit notifications@github.com<mailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.commailto:HATS@noreply.github.commailto:HATS@noreply.github.com> Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.govmailto:HudsonJ@wsdot.wa.govmailto:HudsonJ@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.commailto:assign@noreply.github.commailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZB7CFA3A3EKQLUGY53QNYAXZA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYPDNQ#issuecomment-540078518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZDV3LOYXIQBPRYREH3QNYAXZANCNFSM4I4ZNZVA.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT75OY7KKABNVBGJV4DQNYPOVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY3XRA#issuecomment-540130244, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT4CXNKFJF2DTRMA2HTQNYPOVANCNFSM4I4ZNZVA.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT23FUVBMUBFSEPUSLDQNYQEVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY4KJA#issuecomment-540132644, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT2V4IADHCIAHZCR4JTQNYQEVANCNFSM4I4ZNZVA.

brianblood commented 4 years ago

So, leave HideLocationIndicator = true for snow and ice, yes? What about ShowAvlTrucks = true? Should that stay as well?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joe Schmit notifications@github.com Sent: Wednesday, October 9, 2019 11:38 AM To: WSDOT/HATS HATS@noreply.github.com Cc: Blood, Brian BloodB@wsdot.wa.gov; Assign assign@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Not deprecated but redundant more or less, that would apply to highLocationIndicator

On Oct 9, 2019, at 11:36 AM, Joe Schmit notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:

vm.ShowTimeRange = true; shouldn’t that be deprecated? We now have a flag in admin > feature activities > end date/time?

On Oct 9, 2019, at 11:31 AM, brianblood notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> wrote:

Hey Josh/Joe Any insight on this bit of code when editing an Other Activity?

//Snow and Ice Records Are "Special" if (vm.FeatureTypeName.ToLower() == "snow and ice") { vm.ShowTimeRange = true; vm.ShowAvlTrucks = true; vm.HideLocationIndicator = true; }

This is not happening when creating a new record. I can either remove this bit from Edit, or add it to Add. Preferences?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov<mailto:bloodb@wsdot.wa.gov%3cmailto:bloodb@wsdot.wa.gov%3e%3cmailto:bloodb@wsdot.wa.gov%3e%3cmailto:bloodb@wsdot.wa.gov> | 360.709.8243

From: Joshua Hudson notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:26 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com<mailto:HATS@noreply.github.com%3cmailto:HATS@noreply.github.com>mailto:HATS@noreply.github.com> Cc: Blood, Brian BloodB@wsdot.wa.gov<mailto:BloodB@wsdot.wa.gov<mailto:BloodB@wsdot.wa.gov%3cmailto:BloodB@wsdot.wa.gov>mailto:BloodB@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com<mailto:assign@noreply.github.com%3cmailto:assign@noreply.github.com>mailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.gov<mailto:hudsonj@wsdot.wa.gov%3cmailto:hudsonj@wsdot.wa.gov%3e%3cmailto:hudsonj@wsdot.wa.gov%3e%3cmailto:hudsonj@wsdot.wa.gov> | 360.705.7778


From: Joe Schmit notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.commailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com<mailto:HATS@noreply.github.com%3cmailto:HATS@noreply.github.com>mailto:HATS@noreply.github.commailto:HATS@noreply.github.com> Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.gov%3cmailto:HudsonJ@wsdot.wa.gov>mailto:HudsonJ@wsdot.wa.govmailto:HudsonJ@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com<mailto:assign@noreply.github.com%3cmailto:assign@noreply.github.com>mailto:assign@noreply.github.commailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZB7CFA3A3EKQLUGY53QNYAXZA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYPDNQ#issuecomment-540078518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZDV3LOYXIQBPRYREH3QNYAXZANCNFSM4I4ZNZVA.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT75OY7KKABNVBGJV4DQNYPOVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY3XRA#issuecomment-540130244, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT4CXNKFJF2DTRMA2HTQNYPOVANCNFSM4I4ZNZVA.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT23FUVBMUBFSEPUSLDQNYQEVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY4KJA#issuecomment-540132644, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT2V4IADHCIAHZCR4JTQNYQEVANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZE5VP4OZ7L7NKZ7XMDQNYQINA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY4NMI#issuecomment-540133041, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZBJVGFU4COYDCKXCF3QNYQINANCNFSM4I4ZNZVA.

jhudsonWA commented 4 years ago

Yes I’d say on both

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.gov | 360.705.7778


From: brianblood notifications@github.com Sent: Wednesday, October 9, 2019 3:12:05 PM To: WSDOT/HATS HATS@noreply.github.com Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov; Assign assign@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

So, leave HideLocationIndicator = true for snow and ice, yes? What about ShowAvlTrucks = true? Should that stay as well?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joe Schmit notifications@github.com Sent: Wednesday, October 9, 2019 11:38 AM To: WSDOT/HATS HATS@noreply.github.com Cc: Blood, Brian BloodB@wsdot.wa.gov; Assign assign@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Not deprecated but redundant more or less, that would apply to highLocationIndicator

On Oct 9, 2019, at 11:36 AM, Joe Schmit notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:

vm.ShowTimeRange = true; shouldn’t that be deprecated? We now have a flag in admin > feature activities > end date/time?

On Oct 9, 2019, at 11:31 AM, brianblood notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> wrote:

Hey Josh/Joe Any insight on this bit of code when editing an Other Activity?

//Snow and Ice Records Are "Special" if (vm.FeatureTypeName.ToLower() == "snow and ice") { vm.ShowTimeRange = true; vm.ShowAvlTrucks = true; vm.HideLocationIndicator = true; }

This is not happening when creating a new record. I can either remove this bit from Edit, or add it to Add. Preferences?

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov<mailto:bloodb@wsdot.wa.gov%3cmailto:bloodb@wsdot.wa.gov%3e%3cmailto:bloodb@wsdot.wa.gov%3e%3cmailto:bloodb@wsdot.wa.gov> | 360.709.8243

From: Joshua Hudson notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:26 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com<mailto:HATS@noreply.github.com%3cmailto:HATS@noreply.github.com>mailto:HATS@noreply.github.com> Cc: Blood, Brian BloodB@wsdot.wa.gov<mailto:BloodB@wsdot.wa.gov<mailto:BloodB@wsdot.wa.gov%3cmailto:BloodB@wsdot.wa.gov>mailto:BloodB@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com<mailto:assign@noreply.github.com%3cmailto:assign@noreply.github.com>mailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

Brian can you check this today?

Joshua Hudson Applications Modernization Manager, Enterprise Applications hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.govmailto:hudsonj@wsdot.wa.gov<mailto:hudsonj@wsdot.wa.gov%3cmailto:hudsonj@wsdot.wa.gov%3e%3cmailto:hudsonj@wsdot.wa.gov%3e%3cmailto:hudsonj@wsdot.wa.gov> | 360.705.7778


From: Joe Schmit notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.commailto:notifications@github.com> Sent: Wednesday, October 9, 2019 9:20:03 AM To: WSDOT/HATS HATS@noreply.github.com<mailto:HATS@noreply.github.com<mailto:HATS@noreply.github.com%3cmailto:HATS@noreply.github.com>mailto:HATS@noreply.github.commailto:HATS@noreply.github.com> Cc: Hudson, Joshua HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.gov<mailto:HudsonJ@wsdot.wa.gov%3cmailto:HudsonJ@wsdot.wa.gov>mailto:HudsonJ@wsdot.wa.govmailto:HudsonJ@wsdot.wa.gov>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com<mailto:assign@noreply.github.com%3cmailto:assign@noreply.github.com>mailto:assign@noreply.github.commailto:assign@noreply.github.com> Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

bump...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QCHGJCAMMJM73LDJ3QNYADHA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYOSPI#issuecomment-540076349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFLP3RHFXKUKUJLEZ6HJMLQNYADHANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZB7CFA3A3EKQLUGY53QNYAXZA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYPDNQ#issuecomment-540078518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZDV3LOYXIQBPRYREH3QNYAXZANCNFSM4I4ZNZVA.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT75OY7KKABNVBGJV4DQNYPOVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY3XRA#issuecomment-540130244, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT4CXNKFJF2DTRMA2HTQNYPOVANCNFSM4I4ZNZVA.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAGYBT23FUVBMUBFSEPUSLDQNYQEVA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY4KJA#issuecomment-540132644, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGYBT2V4IADHCIAHZCR4JTQNYQEVANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZE5VP4OZ7L7NKZ7XMDQNYQINA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY4NMI#issuecomment-540133041, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZBJVGFU4COYDCKXCF3QNYQINANCNFSM4I4ZNZVA.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=AAFLP3QU6X72ELFVV7ANVT3QNZJLLA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAZTCJY#issuecomment-540225831, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFLP3UCHCXKC5NXTRNF3UDQNZJLLANCNFSM4I4ZNZVA.

joeschmit commented 4 years ago

So the only "things" that should be on the form are the form questions themselves and anything set in the admin screen.

jhudsonWA commented 4 years ago

K, let me chat with Brian a bit more on this. We want to make it consistent. I think this is a case where we added flags to allow admins to disable things and there is some historical code overriding.

joeschmit commented 4 years ago

Ya, this one goes back for years...PDA era...

jhudsonWA commented 4 years ago

@brianblood did this ever get pushed out? Where do we stand on these changes (web side)

brianblood commented 4 years ago

Not pushed out yet. I was rolling this fix in with the removal of vehicle selection on the iPad, since they touched the same snow and ice special case on web. Had to re-add the changes after your work on git Friday morning, so I’m just testing it now.

Brian Blood Mobile Application Developer [cid:image001.png@01D496DE.F3223B40] bloodb@wsdot.wa.govmailto:bloodb@wsdot.wa.gov | 360.709.8243

From: Joshua Hudson notifications@github.com Sent: Monday, October 21, 2019 12:19 PM To: WSDOT/HATS HATS@noreply.github.com Cc: Blood, Brian BloodB@wsdot.wa.gov; Mention mention@noreply.github.com Subject: Re: [WSDOT/HATS] HATS Web: Other > Snow and Ice > Winter Event > Edit > Requiring End Date/Time (#1368)

@brianbloodhttps://github.com/brianblood did this ever get pushed out? Where do we stand on these changes (web side)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/WSDOT/HATS/issues/1368?email_source=notifications&email_token=ADYF2ZEYIV53BFAWJ5CKSU3QPX6DXA5CNFSM4I4ZNZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3PDMY#issuecomment-544666035, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYF2ZCBAXGD64S5ZKA6IH3QPX6DXANCNFSM4I4ZNZVA.

brianblood commented 4 years ago

This is in QA, just need to test changes to the snow and ice forms to make sure they are functioning the same with my new changes.

brianblood commented 4 years ago

Fixed!