Open WSH032 opened 5 months ago
Attention: Patch coverage is 85.41667%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 96.39%. Comparing base (
977d9c1
) to head (3d2b0ea
).
Files | Patch % | Lines |
---|---|---|
src/fastapi_proxy_lib/core/websocket.py | 84.09% | 10 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The test succeeded on Windows but failed on Linux, preventing us from merging. Unfortunately, I don't have time to address this issue at the moment. If someone is willing to pick it up, I can provide guidance.
the return signature of ReverseWebSocketProxy.proxy has been changed
in this commit
Let's keep the original signature so users can handle responses themselves; we should provide a helper method to assist users in sending denial responses rather than sending responses ourselves....
to represent default parameters instead of importing these private variables from httpx-ws
https://github.com/WSH032/fastapi-proxy-lib/blob/3d2b0ea27a0b083886c1d03e37645bb5a7050dfa/tests/test_ws.py#L212-L215 This is an upstream issue of ASGI, and we are unable to address it. We will track it here frankie567/httpx-ws#70.
WebSocketUpgradeError.response
https://github.com/WSH032/fastapi-proxy-lib/blob/3d2b0ea27a0b083886c1d03e37645bb5a7050dfa/src/fastapi_proxy_lib/core/websocket.py#L440-L442
This is an upstream issue of httpx-ws
, We will track it here
frankie567/httpx-ws#69
StreamingResponse
in favor of Response
https://github.com/WSH032/fastapi-proxy-lib/blob/3d2b0ea27a0b083886c1d03e37645bb5a7050dfa/src/fastapi_proxy_lib/core/websocket.py#L431-L438
This is an upstream issue of starlette
, We will track it here
encode/starlette#2566
I am aware of such downstream use cases, so we cannot deprecate the path
parameter, which can allow us to add a dynamic path prefix.
Summary
Added
Changed
ReverseWebSocketProxy.proxy
has been changed; it no longer returnsStarletteResponse
, but instead returnsTrue
Test
httpx
Checklist
CONTRIBUTING.md
.