WSTxda / MicroG-RE

GmsCore fork for ReVanced with Material You, features and improvements
Apache License 2.0
1.01k stars 24 forks source link

version 5.4 has broken installer #18

Closed imonxda2 closed 4 months ago

imonxda2 commented 4 months ago

I tested installer for latest version 5.4 on multiple devices with different architectures and on multiple Android versions. The installer will produce an error "There was a problem parsing the package" or it will be in a perpetual state of "installing" until you force quit. I tested version 5.3 on these same systems and it installs and works fine.

WSTxda commented 4 months ago

If you are on a rom that scans apk, like HyperOS, try disabling this, by default MicroG supports multiple architectures and the sign key is registered as an organization.

WSTxda commented 4 months ago

You can try redownloading the version and check for an error again

imonxda2 commented 4 months ago

No. I already did all that, and on multiple roms, I have multirom so I can test it on no less than 130 roms, if I want to. I tested it over and over on at least 8 roms all were Android 6-7 and all subversions, downloaded multiple copies over the course of a few days just to make sure - but the fact that the previous version 5.3 installs and works on all the same roms I tested 5.4, should tell you something. If you think there is nothing wrong with v5.4, by all means don't pay any attention to me, I'm using v5.3 and am very happy, by the way, great work on this, it's super streamlined compared to all the other Micro-G out there, and another BTW, your app is not LP compatible, tho there exists a LP Re-Vanced Youtube that could use a good MicroG.

WSTxda commented 4 months ago

Well, that's a really strange report, there is no commit that reflects anything specifically.

Note that MicroG is min sdk 23 which means only marshmallow (Android 6) and higher is supported.

Then ReVanced fork which supports android 5-6 is not listed as recommended patchers.

imonxda2 commented 4 months ago

OK. I just tested it again, I downloaded 5.4 with PC Firefox and also with Firefox in AOSP 7.1.2 rom. . Both installers behave the same. The 5.4 installer opens, you can tap INSTALL, then I get "App not installed. The package appears to be corrupt." Then I downloaded v5.3 on the same rom in the same way, and it installs and works fine. I also have multiple devices like Sam-S7, HTC M9, which are ARM64, and the device with multirom is HTC M8 ARMv7 - they all behave the same. On other roms I can't even open the installer I get "There was a problem parsing the package", or the installer opens, but once you tap INSTALL it goes on endlessly till you FC - but the v5.3 works fine every time. This is all I can tell you.

imonxda2 commented 4 months ago

It may be that this particular 5.4 apk had some problem during compiling and if you just re-compile fresh, maybe its fine, IDK, I'm not a dev, but I am dead sure about what I just reported. As for the SDK23, I already knew that, I was hoping you would be willing to make it SDK21+, so it CAN be used on LP, because it seems to be the most streamlined MicroG, and LP devices are old and could really use a small-sized MicroG to go with ReVanced for LP.

imonxda2 commented 4 months ago

So I just tested 5.4 on And13 tablet SM-T220 - it works fine! My previous guess that it may be miss-compiled is wrong. Obviously the problem is only on And6-7, I could install some Oreo rom to see if it installs on that, but that would take some time. I believe you probably did not test this 5.4 on And6-7, am I right?

imonxda2 commented 4 months ago

I tested 5.4 on And8 AOSP, it fails, "App not installed". v5.3 on the same rom works "App installed". I will test And9-12 - 13 already confirmed working, I'll let you know.

imonxda2 commented 4 months ago

I just tested on And9 and v5.4 works fine. So I'm assuming it will probably work on And10-12 and 14. Final result, v5.4 installer fails for all Android versions 6-8.1, but v5.3 installs on all supported And. versions.

WSTxda commented 4 months ago

ok, will check this in emulator before releasing future build.