WSWCWaterDataExchange / MappingStatesDataToWaDE2.0

Manage all code to map and import state's data into WaDE 2.0
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Owner classification: Us Dept Of The Interior #253

Closed amabdallah closed 8 months ago

amabdallah commented 9 months ago

Two things to consider in the classification algorithm

  1. Let's classify "Us Dept Of The Interior" as United State Of America". Here is an example https://westdaat.westernstateswater.org/details/right/NMwr_WRSP02849

  2. The algorithm needs to be smarter regarding the existence of "USA" in the owner name. In this example, a private company has "USA" in its name so it got classified as United States of America which is not correct. https://westdaat.westernstateswater.org/?state=N4Ig7gTiBcoPZgHYFMIGEA2BDAzjglgGb4DGWALvnIjjANogCqi%2B5yAJgAQDK5FyOTnEKcAggFtUpLCAC6AGhD4cAOQzt8AMXwY2EUSUoA3ZDEJYMOZAF9rQA

image

rwjam commented 8 months ago

Added "Us Dept Of The Interior" keyword to the United State Of America group.

Will included the following new keywords into “Private” to help cut down on similar issues. These are keywords I noted in AZwr alone and is not a complete total comprehensive list. I think we can continue to add on to: Amoco, assurance, bank, business, cemex, center, chemical, chevron, christian, church, cocacola, estate, estates, exxon, farley's, farmers, fertilizer, freedom, gold, hallelujah, home, insurance, lc, limited, lllp, minerals, nestle, prayer, production, ranch, ranches, real, scouts, Toyota, Walton, waste, Texaco, Antea, Velcro, Epcor, Confac, Mattamy, Phillip.

Update AZwr & NMwr to reflect these changes on the uat, will slowly update other states’ water rights to reflect these changes as we continue to review projects and data.

Updated Owner Classification functionality. https://github.com/WSWCWaterDataExchange/MappingStatesDataToWaDE2.0/tree/master/5_CustomFunctions/OwnerClassification

amabdallah commented 8 months ago

I love this Excel table. Did you do it manually? I think it would be helpful to pivot it (swap rows and columns), which makes it easy to show/present as ~20 rows (classifications) and then multiple columns for the values. I then could create comma-separated values to show them in a Word Document for presentations etc

rwjam commented 8 months ago

Let's leave the table as is. It's being used with the code / it's simple to add new items to each list & create new list / verify we want already using the same keyword.

If you need a copy of it for a word doc report, I'd say just copy the xlsx file to your local machine and manipulate it to fit the doc better.