search

WSWCWaterDataExchange / MappingStatesDataToWaDE2.0

Manage all code to map and import state's data into WaDE 2.0
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Review NEwr Bearura of Reclmation Issue #298

Closed amabdallah closed 9 months ago

amabdallah commented 9 months ago

Reference: https://github.com/WSWCWaterDataExchange/MappingStatesDataToWaDE2.0/tree/master/5_CustomFunctions/OwnerClassification

I'm not sure why the code is classifying this owner's name as Reclamation. It appears that the word "Trust" was picked up as Reclamation which is not correct. I dont see the "trust" keyword anywhere in the Excel file or the code. Weird. https://westdaat.westernstateswater.org/details/right/NEwr_WRA008024

It appears the issue exists for many other water rights in Nebraska: see the table below https://westdaat.westernstateswater.org/?state=N4Ig7gTiBcoPZgHYFMIGEA2BDAzjglgGb4DGWALvnIjjANogBCArhMlswAQBKyJ2AWwpVEnABQBVAMqNuAShABdADQh8OAHIYAJvgBi%2BDOVQBBEpQBuyGISwYcyVTnIVktaAw0BRJQF9VQgAOMKAAXnBwAgAyyFYYMAAcAHQA7ADMKQCcAEwArABsaZkAjAAMmUWq2JTkzNrW0AAspUmZCcXFCVXUAOb4tfUwALSZmUkJmSn5vr5AA image

image

rwjam commented 9 months ago

Issue solved with re-downloading the data from the API services. re-downloaded data is newer and does not have this problem.

New issue of NEwr API services no longer support / provide a native site ID value. This means we will have to create our own which will cause issues with our NLDI tool.