WSWUP / agweather-qaqc

Visualized QA/QC of weather station data
https://wswup.github.io/agweather-qaqc/
Apache License 2.0
19 stars 11 forks source link

implicit imports #1

Closed dgketchum closed 5 years ago

dgketchum commented 6 years ago

Great package!

for readability please use explicit imports:

from foo import bar

is better than

from foo import *

because later in the code we see

bar.do_something() rather than do_something which is good because a new user reading your code knows where

do_something() came from

cwdunkerly commented 5 years ago

Thank you for the suggestion. All imports are now either explicit or name the package the function came from.