[Feature Request] include reproducible results from JOSS paper fig 2

WSWUP / agweather-qaqc

Visualized QA/QC of weather station data

https://wswup.github.io/agweather-qaqc/

Apache License 2.0

20 stars 11 forks source link

[Feature Request] include reproducible results from JOSS paper fig 2 #28

Closed dlebauer closed 6 months ago

dlebauer commented 7 months ago

Please describe the feature you'd like to see

Regarding https://github.com/openjournals/joss-reviews/issues/6368, JOSS Requires 'reproducibility' defined as

If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.

Please add the example data and script or README to reproduce the analysis in the "paper" folder or subdirectory thereof.

cwdunkerly commented 6 months ago

I have included the files necessary to re-create the figure and instructions in a markdown file of the steps to go through. They are located here: https://github.com/WSWUP/agweather-qaqc/tree/master/tests/test_files/joss_figure_2

Please let me know if this is insufficient, I am not going to close this until I have your sign off.

dlebauer commented 6 months ago

Looks great, thank you!