Closed jes16jupyter closed 4 months ago
@github-actions[bot] is attempting to deploy a commit to the WTF Team on Vercel.
A member of the Team first needs to authorize it.
Hi @AmazingAng Could you plz take a look? You can switch to this branch, and just call source sync.sh
.
@chongqiangchen pls review
@AmazingAng
得让后端看下这样重命名有没有影响
@jes16jupyter
或许可以考虑减少对sync.sh插入特定仓库的处理代码,这里看起来或许可以把sync-meta.py改造成执行的方案为:python3 sync-meta.py docs/solidity-101
,然后将这个作为scripts插入到sync.json?
得让后端看下这样重命名有没有影响
这个不会有影响
@chongqiangchen 就这个吗,其他还需要修改吗?
@jes16jupyter 或许可以考虑减少对sync.sh插入特定仓库的处理代码,这里看起来或许可以把sync-meta.py改造成执行的方案为:
python3 sync-meta.py docs/solidity-101
,然后将这个作为scripts插入到sync.json?
我觉得这个说的很好,我修改一下,避免侵入性
@chongqiangchen 就这个吗,其他还需要修改吗?
暂时看起来就这个~其他的感觉没啥问题
好的。我明天处理一下
大雄呀 @.***> 于2024年6月15日周六 21:43写道:
@chongqiangchen https://github.com/chongqiangchen 就这个吗,其他还需要修改吗?
暂时看起来就这个~其他的感觉没啥问题
— Reply to this email directly, view it on GitHub https://github.com/WTFAcademy/frontend/pull/191#issuecomment-2169659477, or unsubscribe https://github.com/notifications/unsubscribe-auth/BETH54DB4BJ7ZANBO3KV7ITZHRAGHAVCNFSM6AAAAABJB5WQKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGY2TSNBXG4 . You are receiving this because you were mentioned.Message ID: @.***>
@AmazingAng @chongqiangchen Fixed. Plz check
@chongqiangchen Hi, could you plz take a look~
今天或者明天我来看一下~
jes16jupyter @.***>于2024年6月20日 周四17:52写道:
@chongqiangchen https://github.com/chongqiangchen Hi, could you plz take a look~
— Reply to this email directly, view it on GitHub https://github.com/WTFAcademy/frontend/pull/191#issuecomment-2180275386, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMF42GLLUINBCWA5EBIA7DZIKQ4RAVCNFSM6AAAAABJB5WQKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGI3TKMZYGY . You are receiving this because you were mentioned.Message ID: @.***>