Closed djablonski-moia closed 1 year ago
Thank you for this report. I’ll start looking at it ASAP.
Seems like every release has a breaking bug on either the Firefox or chrome side. If anybody has good ideas on cross platform testing I’m all ears.
On Wed, May 31, 2023 at 4:57 AM Dirk Jablonski @.***> wrote:
Extension Version
1.4.0 Description
After the latest update to v1.4.0, new accounts being added do not show up in the accounts listanymore (but they do on the AWs start page). Also, adding Accounts to Favorites rarely works as intended. Most times, the star is immediately de-selected again in the accounts list, when trying to add an account as Favorite. Browsers
Firefox OS
Linux
— Reply to this email directly, view it on GitHub https://github.com/WTFender/aws-sso-extender/issues/37, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SA545RERCSVVHDQWSYQTXI4IWZANCNFSM6AAAAAAYVGTW6A . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@djablonski-moia If you don't mind, could you take a screenshot of what permissions your extension currently has?
I'm not able to reproduce the account list issue, but do think I caused this with all the permission changes recently.
The profile/account list should get updated in the extension when you visit the AWS SSO page. I'm assuming that the permissions were messed up between version upgrades and it can't grab the new accounts when you're on this page.
Unfortunately, I can't reproduce the favorite issue either - has that ever worked properly for you?
If you're comfortable exporting your user config and sending it to me (there is nothing sensitive in there except your AWS account IDs, role names, etc.), I can look into this a bit more. Paste it here or email wtfender.cs
Thanks for the quick response @WTFender!
Here are the current permissions:
My user config will follow later (and via email, too large for here with > 100 accounts)
Woah that’s a lot of accounts. We may be running into storage limits; which would make sense why changes aren’t saving. I’ll do some bulk testing today.
On Thu, Jun 1, 2023 at 2:24 AM Dirk Jablonski @.***> wrote:
Thanks for the quick response @WTFender https://github.com/WTFender! Here are the current permissions: [image: image] https://user-images.githubusercontent.com/49818625/242516649-db99fb87-7e2c-479e-88b4-a8e0a5c3cba0.png My user config will follow later (and via email, too large for here with > 100 accounts)
— Reply to this email directly, view it on GitHub https://github.com/WTFender/aws-sso-extender/issues/37#issuecomment-1571499452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SA57D3DUCK2HYJ4QBVMTXJA7SXANCNFSM6AAAAAAYVGTW6A . You are receiving this because you were mentioned.Message ID: @.***>
I can't promise this update will preserve your existing account data, but it will try. If things look weird, just reinstall and you should be good to go with many more accounts. If you have a lot of customizations, you can snip those out of your user config JSON and paste them back in once reinstalled.
I was able to reproduce and fix this I believe, but let me know if it persists for you.
Sorry for the long time until giving feedback. Yes, issue with favorites is solved. The other is something I need to investigate deeper locally, as I'm not sure if this is just our setup. Thank you!
Extension Version
1.4.0
Description
After the latest update to v1.4.0, new accounts being added do not show up in the accounts list anymore (but they do on the AWs start page). Also, adding Accounts to
Favorites
rarely works as intended. Most times, the star is immediately de-selected again in the accounts list, when trying to add an account as Favorite.Browsers
Firefox
OS
Linux