search

WTIOAddons / date-time-adapter

Group Collaboration on date-time-adapter by all contributors with a special thanks to tomasy for original project
Mozilla Public License 2.0
0 stars 1 forks source link

Required Python version not supported by WebThings Gateway 1.0 #12

Closed benfrancis closed 2 years ago

benfrancis commented 2 years ago

In https://discourse.mozilla.org/t/newbie-question-about-missing-addons/107097/5 it was reported that users of the WebThings Gateway 1.0 Raspberry Pi OS image are not seeing the date time adapter as available to install.

This appears to be because in the 1.1.6 release of the adapter, support was dropped for Python 3.7.

Unfortunately Python 3.7 is the latest version available in Raspbian/Debian Buster, upon which the WebThings Gateway 1.0 image is built (and likely some future releases will be built too).

When a gateway fetches the list of available add-ons it specifies the installed Python version in its request. If the add-on requires a newer version than the one installed then it isn't displayed.

Is there a functional reason why Python 3.8 is required, or could Python 3.7 support return?

wfahle commented 2 years ago

I couldn't get it to build a 3.7 image for the required targets using github. I think we may need to roll back to the prior release of datetimeadapter.

On Mon, Oct 31, 2022, 6:19 AM Ben Francis @.***> wrote:

In https://discourse.mozilla.org/t/newbie-question-about-missing-addons/107097/5 it was reported that users of the WebThings Gateway 1.0 Raspberry Pi OS image are not seeing the date time adapter as available to install.

This appears to be because in the 1.1.6 release of the adapter, support was dropped for Python 3.7.

Unfortunately Python 3.7 is the latest version available in Raspbian/Debian Buster, upon which the WebThings Gateway 1.0 image is built (and likely some future releases will be built too).

When a gateway fetches the list of available add-ons it specifies the installed Python version in its request. If the add-on requires a newer version than the one installed then it isn't displayed.

Is there a functional reason why Python 3.8 is required, or could Python 3.7 support return?

— Reply to this email directly, view it on GitHub https://github.com/WTIOAddons/date-time-adapter/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVN4BZYCTFOUQ3B2XTXYMTWF6TLFANCNFSM6AAAAAARS7D6DI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

wfahle commented 2 years ago

I got this to build and there is a pending merge request for addons to push it to the current build. There are lots of pending deprecations of build actions, so any future updates will require quite a bit more pain. But this one is done; closing out.

flatsiedatsie commented 1 year ago

No need for pain, just copy my workflow: https://github.com/createcandle/matter-adapter/blob/main/.github/workflows/release.yml

wfahle commented 1 year ago

Hmm, it looks like you've left out v3.7 in your workflow. If you look at mine you will see that I changed the build for 3.7 to not rebuild everything from scratch, and just to use existing wheels and whatnot. It all works fine now.

flatsiedatsie commented 1 year ago

Ah, here: https://github.com/WTIOAddons/date-time-adapter/blob/ed13e5a684d2bd8eed950a0f22515fcc707cc317/package.sh#L23

I was curious about that. @benfrancis Why does it normally build everything from scratch? Is that for security reasons?

wfahle commented 1 year ago

That was the way the sample I copied did it. No idea why.

On Fri, Feb 3, 2023, 7:33 AM flatsiedatsie @.***> wrote:

Ah, here:

https://github.com/WTIOAddons/date-time-adapter/blob/ed13e5a684d2bd8eed950a0f22515fcc707cc317/package.sh#L23

I was curious about that. @benfrancis https://github.com/benfrancis Why does it normally build everything from scratch? Is that for security reasons?

— Reply to this email directly, view it on GitHub https://github.com/WTIOAddons/date-time-adapter/issues/12#issuecomment-1415876577, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVN4B6YH77RH7HGYMGGLGLWVUCJVANCNFSM6AAAAAARS7D6DI . You are receiving this because you modified the open/close state.Message ID: @.***>