[Modal] modal types doesn't use ariakit dialog types

WTTJ / welcome-ui

Customizable design system from Welcome to the jungle (@wttj) with react, typescript, styled-components, ariakit and a lot of love 💛 Here you'll find all the core components you need to create a delightful webapp.

https://www.welcome-ui.com

MIT License

612 stars 51 forks source link

[Modal] modal types doesn't use ariakit dialog types #2313

Open jeromeraffin opened 9 months ago

jeromeraffin commented 9 months ago

For which component/foundations?

Modal

Prioritization

Medium ⛰️

Description

The modal component is based on ariakit dialog component but we're not using the types from it. For example if I want to use the backdrop props on the modal component, typescript gives us an error. https://ariakit.org/examples/dialog-backdrop-scrollable#rendering-a-custom-backdrop

[Tech] Implementation

No response

Due Date

No response

alissiagelabert commented 9 months ago

Once this ticket is solved decomment following tests:

test_cypress/cypress/e2e/showcase/critical/Showcase - cover - picture - fullscreen.feature
test_cypress/cypress/e2e/showcase/low/Showcase - preview link - close click outside.feature
test_cypress/cypress/e2e/showcase/medium/Showcase - block video - play close.feature