search

WTW-IM / es-components

React components built for products in Exchange Solutions
https://wtw-im.github.io/es-components/
18 stars 35 forks source link

ENIFP-3285: Allow Modal Header Size Alteration #808

Closed bradyclifford closed 7 months ago

bradyclifford commented 10 months ago

Currently the size of the header cannot be changed.

bradyclifford commented 10 months ago

I am sure I am missing some things in this PR. For now this is just a proposal.

bradyclifford commented 8 months ago

Any idea why the Cypress tests are failing? Its failing on components this PR does not even touch.

bradyclifford commented 8 months ago

Commitlint

commitlint results

The following commit messages do not meet our commit convention. Please reword these commits for correct versioning and changelog generation.

  • Allow Modal Header Size Alteration

    • subject may not be empty
    • type may not be empty
  • Update packages/es-components/src/components/containers/modal/ModalHeader.tsx

Co-authored-by: Steve Matney steve.matney@extendhealth.com subject may not be empty type may not be empty

  • Update packages/es-components/src/components/containers/modal/ModalHeader.tsx

Co-authored-by: Steve Matney steve.matney@extendhealth.com subject may not be empty type may not be empty

  • Update packages/es-components/src/components/containers/modal/ModalHeader.tsx

Co-authored-by: Steve Matney steve.matney@extendhealth.com subject may not be empty type may not be empty

  • New: Allow modal header level alteration

    • subject must not be sentence-case, start-case, pascal-case, upper-case

Every commit has to have that format?

stevematney commented 7 months ago

Every commit has to have that format?

@bradyclifford yes.

stevematney commented 7 months ago

Any idea why the Cypress tests are failing? Its failing on components this PR does not even touch.

It's failing because HeadingLevel is only a type and not a js variable, so it can't build. That's why I recommended this change.

https://github.com/WTW-IM/es-components/blob/cf2556f5b045f10043a5bb23e9e54250ebbe2573/shared/types/src/ESTheme.ts#L206

bradyclifford commented 7 months ago

Any idea why the Cypress tests are failing? Its failing on components this PR does not even touch.

It's failing because HeadingLevel is only a type and not a js variable, so it can't build. That's why I recommended this change.

https://github.com/WTW-IM/es-components/blob/cf2556f5b045f10043a5bb23e9e54250ebbe2573/shared/types/src/ESTheme.ts#L206

Oh ya that makes sense. I must of missed that. What I get for trying to make these adjustments from GitHub itself.

github-actions[bot] commented 7 months ago

Commitlint

commitlint results

All commit messages are correctly formatted.