search

WU-BIMAC / MicroMetaApp-React

This is the React implementation of Micro-Meta App, Microscopy Metadata for the real world!
https://wu-bimac.github.io/MicroMetaApp.github.io/
GNU General Public License v3.0
6 stars 1 forks source link

Error with saving: Dichroic does not save content of TR fields when RR components are present #45

Closed strambc closed 4 years ago

strambc commented 5 years ago

Does not save CutIn, CutOut, and Transmittance or TR elements in Dichroic. When hitting Confirm, it allows closing, the red box goes away, but the content of fields is not retained.

Opened in TIer5 Validate in Tier5

tesm_mma_ome_9719.txt

Screen Shot 2019-09-11 at 19 13 32 Screen Shot 2019-09-11 at 19 19 04

strambc commented 5 years ago

Software version: alpha_0.0.15b

strambc commented 5 years ago

Removed problem Dichroic. Created a new one. The same issue presented again.

Investigated some more: It appears that what is happening is that the values of CutIn and CutOut present in RR get copied on the corresponding TR component (RR0 --> TR0, RR1-->TR1, RR2-->TR2, etc.). On the other hand, the Reflectance does not get copied over and it gets emptied out every time (I guess because the corresponding field is missing).

strambc commented 5 years ago

Attempted to fix by removing RR elements in the same Dichroic component. Did not work.

REMOVED Dichroic and did not create any RR components (just 3 TR components) and:

strambc commented 5 years ago

Created new Dichroic element (3 TR and 3 RR components) and the same problem presented. Realized that what happens is that the CutIn and CutOut values in the corresponding RR components get copied over to the TR (i.e. RR1 --> TR1 etc.). However the same does not happen with Reflectance vs. Transmittance. The value in Transmittance gets erased and not replaced with the value in Reflectance.

Attempted to remove RR elements and the same problem persisted. Attempted to create a new Dichroic without any RR components (just 3 TR) and the issue went away.

Akramhar commented 4 years ago

should be fixed in 0.18