WWBN / AVideo

Create Your Own Broadcast Network With AVideo Platform Open-Source. OAVP OVP
https://avideo.tube/AVideo_OpenSource
Other
1.89k stars 972 forks source link

Shorts next button crashes android browser, both brave and chrome #8137

Open fakeologist opened 1 year ago

fakeologist commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

Screenshot_20230629_155959_Device care.jpg

https://github.com/WWBN/AVideo/assets/66537018/f0b16279-6e45-4f1a-b6e0-afd9c073ab39

Works ok on Apple mobile Safari browser.

GreenDragonTavern commented 1 year ago

@fakeologist - On Android if you open a Shorts video and prior to video finishing, close out, does it blow up browser session?

fakeologist commented 1 year ago

No difference although you can't pause and stop a video in shorts

GreenDragonTavern commented 1 year ago

Android and AVideo Shorts do not play nice with each other at all.

DanielnetoDotCom commented 1 year ago

Ok, I will make more tests on android, now you guys are 2 complainings.

what exact Android version are you using? what device?

on the devices I have here, it is working fine.

GreenDragonTavern commented 1 year ago

what exact Android version are you using? what device? Samsung Galaxy S21 - Android v13

fakeologist commented 1 year ago

Samsung s20 fe 5g and android 13

DanielnetoDotCom commented 1 year ago

Ok, I guess the issue is the Android 13, the android 13 for some reason is not available for the developers so I cannot test it the latest Android is 12

image

DanielnetoDotCom commented 1 year ago

I am installing the Android API 34 (that is the latest available) I hope I can reproduce it

DanielnetoDotCom commented 1 year ago

@GreenDragonTavern are you also using brave?

GreenDragonTavern commented 1 year ago

Did a user survey and the phone browsers that came up the most were: Chrome, Firefox, Brave and Edge. I have all installed to verify if there's an issue. I personally use Brave.

DanielnetoDotCom commented 1 year ago

ok, so @GreenDragonTavern and @fakeologist are using brave, can you please check if this error happens only on Brave?

fakeologist commented 1 year ago

Brave and google chrome

GreenDragonTavern commented 1 year ago

Brave, Chrome, Firefox and Edge all fail, so don't think it is browser related.

fakeologist commented 1 year ago

It's says a WebView module above what's that anyway ?

GreenDragonTavern commented 1 year ago

OK, just verified Brave, Edge and Chrome fail. All are built using Chromium. Then there's Firefox and it works flawlessly, no issues. It is the only one of the four not built on Chromium platform. Hope this helps you @DanielnetoDotCom.

DanielnetoDotCom commented 1 year ago

Yes it helps but looks like the issue is only on the latest Android on Chromium

I will release an option where I will remove the animation, so see if it will stop the crashing.

currently, I think it is an Android bug, because Chrome on iPhone works fine.

DanielnetoDotCom commented 1 year ago

I could not remove the animation, also I think this will not resolve.

Currently, I do not know what to do with the Android 13

DanielnetoDotCom commented 1 year ago

I still did not find android 13 to test, but I just tested on android 14 and it works

GreenDragonTavern commented 1 year ago

Nothing is ever easy is it 🙃- And thanks for update.

Quick question, isn't there a more eloquent way to identify Shorts besides duration? Wouldn't using the type field in the end give you more flexibility in 1) identifying, 2) restrictions ie; proper format, duration, 3) Encoder could automatically identify based on Short format and 4) Coding for Shorts is consistent based on specs and not just how long a video lasts.

fakeologist commented 1 year ago

Thanks for the effort. I am guessing most people have 13, I doubt my phone can update to 14. Good excuse to get a new one.

DanielnetoDotCom commented 1 year ago

I still could not test on android 13, but it could also be something on Samsung

DanielnetoDotCom commented 1 year ago

I could test on Android 13 and it works, so I can only suspect it is a Samsung issue

DanielnetoDotCom commented 1 year ago

this update will update some libraries, please check if fixes the Samsung issue.

fakeologist commented 1 year ago

how the shorts title shows up without shorts at all on android. not playing on windows 11 desktop either.

DanielnetoDotCom commented 1 year ago

how the shorts title shows up without shorts at all on android. not playing on windows 11 desktop either.

Sorry what?

fakeologist commented 1 year ago

No videos display Screenshot_20230630_081355_Brave.jpg

fakeologist commented 1 year ago

also shorts don't autoplay on desktop and there is no play button in the middle of the screen to start video.

DanielnetoDotCom commented 1 year ago

I see, check the gallery plugin and disable shorts if you do not want

I will send an update later regarding it

DanielnetoDotCom commented 1 year ago

also shorts don't autoplay on desktop and there is no play button in the middle of the screen to start video.

autoplay is tricky, I cannot guarantee, check this https://github.com/WWBN/AVideo/wiki/Autoplay-and-Browser-Policies

but the play button should be visible. can you give me a sample where you cannot see the button?

DanielnetoDotCom commented 1 year ago

please try this regarding autoplay

GreenDragonTavern commented 1 year ago

Shorts interface is sweet on Firefox. Brave, Chrome and Edge still nukes playing Shorts. BTW, Samsung Galaxy (2nd only to iPhone sales) uses One UI interface and here is link to emulators: https://developer.samsung.com/galaxy-emulator-skin

fakeologist commented 1 year ago

Autoplay worked fine before your changes. Shorts will be great once you figure out the issue.

DanielnetoDotCom commented 1 year ago

@fakeologist I sent you updates, please try now

fakeologist commented 1 year ago

Doesn't crash the browse when scrolling, but also won't play.

Regular videos have no controls on them either, including progress bar

DanielnetoDotCom commented 1 year ago

please make sure you clear your browser cache. I just tested and you are fine now

DanielnetoDotCom commented 1 year ago

chrome-capture-2023-5-30

fakeologist commented 1 year ago

chrome-capture-2023-5-30

It's back to crashing after advance to next video

DanielnetoDotCom commented 1 year ago

I did not see the crash

fakeologist commented 1 year ago

I did not see the crash

It's back to the way it was at the start of this thread. Next video crashes the browser.

DanielnetoDotCom commented 1 year ago

Looks like the crash only happens on Samsung.

I could not reproduce it.

GreenDragonTavern commented 1 year ago

Looks like the crash only happens on Samsung.

I could not reproduce it.

https://developer.samsung.com/galaxy-emulator-skin

fakeologist commented 1 year ago

Looks like the crash only happens on Samsung.

I could not reproduce it.

Too bad because my next phone will be a Samsung as I can't find many of the apps I use daily on iOS.

fakeologist commented 1 year ago

Update: shorts works with Firefox on android 13 Samsung 20 fe 5g

Must be a chromium issue?

DanielnetoDotCom commented 1 year ago

Looks like the crash only happens on Samsung. I could not reproduce it.

https://developer.samsung.com/galaxy-emulator-skin

the skin does not help, it is about the hardware "I guess";

maybe in a next Samsung update it will be fixed

fakeologist commented 1 year ago

Looks like the crash only happens on Samsung. I could not reproduce it.

https://developer.samsung.com/galaxy-emulator-skin

the skin does not help, it is about the hardware "I guess";

maybe in a next Samsung update it will be fixed

If it works in firefox how can it be a Samsung issue?

DanielnetoDotCom commented 1 year ago

Because this is only happening on Samsung. I haven't encountered this issue in the devices I have available here. also I tested on Android 13 without any problem

GreenDragonTavern commented 1 year ago

No biggie, it's not like Samsung dominates the Android market or something like that 🙃

fakeologist commented 1 year ago

No biggie, it's not like Samsung dominates the Android market or something like that 🙃

I detect and appreciate all sarcasm. That said, Daniel has done a great job so far and is one line away from solving this.

GreenDragonTavern commented 1 year ago

Daniel has gotten plenty of kudos here but when I read "maybe in a next Samsung update it will be fixed". One must ponder, did Samsung acknowledge their AVideo bug?

JoshWho commented 1 year ago

It happens on Motorola also. My phone crashes in vertical view. Wide screen does not but vertical crashes when you click the next button. PWA and browser. Also the Like button is blocking the next button in wide view.