WWBN / AVideo

Create Your Own Broadcast Network With AVideo Platform Open-Source. OAVP OVP
https://avideo.tube/AVideo_OpenSource
Other
1.9k stars 971 forks source link

Account bug #8790

Open para2022 opened 9 months ago

para2022 commented 9 months ago

You have 'email' twice is the accounts causing problems with accounts. It should be user name i think but shows email instead. When i try and close the account page it wont let me as its asking for email there when it is already there further down. I have email login set in advanced settings but surely this is not right having to enter email twice? Every time i make a solution to a problem it creates another problem as i need email logins on now cos so many have forgotten their usernames. Currently the account system is very messy.

DanielnetoDotCom commented 9 months ago

Can you please provide a screenshot?

para2022 commented 9 months ago

What of users personal details for all to see? Or edited to show just the labels?

para2022 commented 9 months ago

So currently my name is there how it was before turning on email login. It used to say username there, and that username is still there. I cannot save the account page cos it brings me back to what used to be username and asks for email again. That is super confusing for users. It should still stay as username?

Screenshot 2024-01-12 at 17 31 53

DanielnetoDotCom commented 9 months ago

I see, it is because your username is also the email.

I will send you updates.

para2022 commented 9 months ago

Thats much better thanks mate. Will everyones account be ok as they are though? Obviously if they go into their account it will prompt them to fix the email yea?

DanielnetoDotCom commented 9 months ago

Yes

para2022 commented 9 months ago

ok thank you

para2022 commented 9 months ago

I just spotted something on video owner showing email instead of name in video panel

Screenshot 2024-01-12 at 19 38 06

para2022 commented 9 months ago

Its not changed everyones only mine since i entered my email in what was the username box.

DanielnetoDotCom commented 9 months ago

Check what you have here

image

para2022 commented 9 months ago

also before i could either enter name or email address now it is only accepting email and not name. lol

DanielnetoDotCom commented 9 months ago

Yes, if you select it must be an email you need to make sure it is an email

para2022 commented 9 months ago

i have Do NOT identify user by Username (selected) Do NOT identify user by Email (selected) Do NOT identify user by Name (unselected)

But it still shows email as video owner on upload

DanielnetoDotCom commented 9 months ago

On your front page, I can see this is showing correct.

image

I do not see any problem with showing the email or username in the videos manager.

only the video owner or admin can see it.

para2022 commented 9 months ago

Its the video panel its affecting:

Screenshot 2024-01-12 at 20 01 27

DanielnetoDotCom commented 9 months ago

Sorry, I am not understanding what is the issue or problem

para2022 commented 9 months ago

The video owner is not their name now it is their email instead you can see here

Screenshot 2024-01-12 at 20 04 28

para2022 commented 9 months ago

Screenshot 2024-01-12 at 20 06 18

DanielnetoDotCom commented 9 months ago

If you select the username must be an email the username and the email will be the same.

also there is no problem to show the email or username there.

DanielnetoDotCom commented 9 months ago

Once your users update their usernames, they will also show the email

para2022 commented 9 months ago

But how would i know who these people are in the video panel? LOL i cant identify them by their emails

DanielnetoDotCom commented 9 months ago

you can search in the users manager right?

para2022 commented 9 months ago

seems a ridiculous amount to work to look them up in the user database to see who they are.

para2022 commented 9 months ago

Their must be a much easier way of simplifying the whole account system seems overly complicated for users

DanielnetoDotCom commented 9 months ago

I disagree that is too much work, you can search not in the database, but in the users manager.

but anyway. the owner is now clickable, and you will go to his channel

DanielnetoDotCom commented 9 months ago

also there is no username anymore, since you force everyone to use their email

GreenDragonTavern commented 9 months ago

also there is no username anymore, since you force everyone to use their email

Native login, isn't this just a simple flag to validate (login) by username or email address? Username should never disappear just because you configure AVideo to login by email. Are you replacing username with email in database under such a configuration?

DanielnetoDotCom commented 9 months ago

also there is no username anymore, since you force everyone to use their email

Native login, isn't this just a simple flag to validate (login) by username or email address? Username should never disappear just because you configure AVideo to login by email. Are you replacing username with email in database under such a configuration?

Correct!

GreenDragonTavern commented 9 months ago

That is a terrible design and eliminates option of returning back to username as login validation. Why in the world would you overwrite username with duplicate data (email) when a simple flag establishes login preference and logic handles the rest?

DanielnetoDotCom commented 9 months ago

The username is unique, the email is not mandatory to be unique. that is why I cannot use the email field

GreenDragonTavern commented 9 months ago

The username is unique, the email is not mandatory to be unique. that is why I cannot use the email field

You are going from bad to worse. Your design dictates that email should not be an option regarding login, period end of story. You are overwriting username (which is still a poor design) with data that 1) isn't mandatory and 2) not unique.

DanielnetoDotCom commented 9 months ago

This is your opinion!! thanks anyway

GreenDragonTavern commented 9 months ago

Overwriting a primary key field with data that isn't mandatory is not opinion.

DanielnetoDotCom commented 9 months ago

Username is not primary, it is unique

GreenDragonTavern commented 9 months ago

Overwriting a unique key field with data that isn't mandatory is not opinion.

DanielnetoDotCom commented 9 months ago

OMG, I am not willing to explain

GreenDragonTavern commented 9 months ago

You don't have to. Understand exactly what AVideo does when enabling email validation. My suggestion is if you're going to allow login using email then the email field should be defined as mandatory and unique, no different than username. This way there is no writing over username with email, and logic dictates the database field to validate.

para2022 commented 9 months ago

Hi greendragon i am guessing Dan has not been willing to move forward on this because changing the whole system could break the site/plugins in other ways and he would have to re-write the whole code? Im not sure I'm not a coder on that scale. Dan has always from my experience fixed issues and for a single developer he does great work even though sometimes I don't agree and get angry and frustrated. It is his project after all. I am not happy with the user system i do think it could be simplified. Name and username is very confusing. Name should be just part of the registration so at least each username has a real name, but not part of the AVideo system. Any system I have ever used uses username and password on the live part of the system. Because of the way it is now if Dan was to change it then it could mess other users sites up? I dunno. i.e if he removed name and users front pages are using peoples names and not username then it could mess them up.

In an ideal world those 3 options in the custoamsdvanced should go and the system should be simplified to username and email without any need for additional options and that users can login with username or email. Im assuming Dan is been over cautious here. I don't even know if it's possible now. Maybe it would be if the AVIdeo script was only just released and not active on peoples sites. I don't know mate i'm just trying to play devils advocate here. I don't know what the solution is but all i know is it is quite messy and with AVideo being such an awesome platform its a shame it doesn't have a much more sensible login/registration system and certain aspects like this let the platform down and its a crying shame, but i do appreciate all his hard work. The forgot password function is a mess for instance. Nobody knows they have to enter their name and then press it. users are generally not very bright and you can relate to this and in development you always have to take that into account. Not everyone is as clued up as us, most are stupid. You should be able to press the forgot password and in its popup it asks for your email address there (not username) and enter the captcha there and that is more logical and simplistic. I get endless emails saying they cant understand it and I agree.

I have learned that we should work together on the project to find solutions rather than slag his work off as hes only human and has feelings and it doesn't get us anywhere in long run. I myself have put a lot of money into the project over the past year and have spend days helping him fix and work out site breaking bugs, for everyones sakes not just my own selfish needs. Thats how opensource works.

GreenDragonTavern commented 9 months ago

Hello @para2022 - In this instance Daniel's shorts got in a bunch for no reason. Users table has two unique keys defined (id as primary, user as unique). Based on design, user is the only sensible option to validate login (nobody is going to know their id number to login with). This is a guess but initial design of AVideo did not consider email as a login option and came about later on. The email field is not indexed, defaults to NULL, is 209 bytes larger and allows duplicates, thus eliminating its data as a login mechanism/user field replacement for any up and running AVideo system.

Simply put, implement email as the login mechanism immediately after install and never look back, otherwise, never use email as login unless addicted to chaos 😉

para2022 commented 9 months ago

I received this before. That user has never logged in. He must be confused with his username. Obviously the below is edited for security purposes.

A new user has signup name: Rolando user: his_email@gmail.com captcha: (edited) redirectUri: email: his_email@gmail.com comment:

GreenDragonTavern commented 9 months ago

Unfortunately using email as login in AVideo is a kludge. Since you have already committed, a follow up email immediately after registration may be necessary clarifying login process and nomenclature.

para2022 commented 9 months ago

Dan you know if i go to the admin user panel? If i change my username back from the email address to my name again then i can login as both username and email and if i upload then it shows my name again how it should be rather than the email address. How weird. But i cannot do it in the account though.

DanielnetoDotCom commented 9 months ago

@para2022 only admin can do it

para2022 commented 9 months ago

ok thanks