search

WXYC / wxyc-ios-64

A new WXYC iOS app
MIT License
7 stars 3 forks source link

Fix storyboard breaks, and then some #17

Closed jakebromberg closed 7 years ago

jakebromberg commented 7 years ago

Okay, so these changes might be controversial, but bear with me. In addition to fixing what I broke the other day, I changed the model of looking at the info view from a push navigation style transition to a paginated, swipe transition. I figure that when we add back the favorites list, this will come in handy, as we'll then allow the user to swipe over to the left to see their favorites. Download the PR and give this a spin. Lemme know what you think.

dvdokkum commented 7 years ago

will take a look tonight and release a new test flight version

dvdokkum commented 7 years ago

I'm cool with the new swiping pattern, but I think if we do it we'll need to add a visual cue to help people understand the new design. Just a simple dot navigation should do it. Also, the volume control is borked, see my note on this issue.

Also just want to keep in mind where we want to go with different screens to make sure we're not backing into a corner here. I imagine the fully completed app will have the following screens:

Main View -- Info View -- Favorites View -- Playlist View -- Contact the DJ

I imagine in the swipe nav paradigm we'd do something like this:

Favorites << Playlist << [Now Playing] >> Info View ...and we could make the contact screen a modal sort of thing off the Now Playing view.

Other random stuff/bugs on this PR:

jakebromberg commented 6 years ago

Do you think the "contact dj" thing should just kick off a tweet?

On Sun, Nov 19, 2017 at 11:58 AM, dvd notifications@github.com wrote:

I'm cool with the new swiping pattern, but I think if we do it we'll need to add a visual cue to help people understand the new design. Just a simple dot navigation should do it. Also, the volume control is borked, see my note on this issue https://github.com/WXYC/wxyc-ios-64/issues/18.

Also just want to keep in mind where we want to go with different screens to make sure we're not backing into a corner here. I imagine the fully completed app will have the following screens:

Main View -- Info View -- Favorites View -- Playlist View -- Contact the DJ

I imagine in the swipe nav paradigm we'd do something like this:

Favorites << Playlist << [Now Playing] >> Info View ...and we could make the contact screen a modal sort of thing off the Now Playing view.

Other random stuff/bugs on this PR:

-

The app always restarts the stream when it comes into focus. We should not reset when the user is listening in the background, nor should we reset (and play) when the user is not in a play state... i.e. the app shouldn't begin streaming when it comes in to focus, only when the user hits play.

Album art is no longer showing in the Control Panel now playing view

On iPhone SE, new load image looks terrible (very low res)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WXYC/wxyc-ios-64/pull/17#issuecomment-345544696, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbNVqUa4T_l-f8wjqU9dQSkPriSe-_0ks5s4IhOgaJpZM4Qimx7 .