Open irvinlim opened 7 years ago
I suggest that we remove linkUrl
, CountryAlpha2Code
and logoUrl
as they are repetitive, terms
as we indicate by month not terms, and emailDomains
as it's hard to bootstrap this data?
Also what bgImageUrl
is used for? Guess we can remove it also? @WYHNUS
bgImageUrl
is background image for University, which is now default to the same image for all Uni, but useful in the future.
emailDomains
is potentially useful in the future for verification of student's validity (I guess).
Let's keep those two there for now.
I will check other fields when I'm back home, and will update schema accordingly. :)
Let's remove linkUrl
, logoUrl
and countryCode
Reason being, the first two are duplicated and neither countryCode
nor CountryAlpha2Code
should be present in the University
table as it is linked with Country
table.
@irvinlim Do you think topUnisId
is necessary, I don't see how we are going to use that though...
Meanwhile, CountryAlpha2Code
is not present in University
table, it is a primary key for Country
.
I suggest we should keep emailDomains
column as it is potential useful in the future.
But do you guys think we will use terms
column? @plsgibchance
@ZhangHanming Can help to do data migration to
University
and Country
tables together@ZhangHanming Will need you to link University and Country tables together for production before we launch v2.0, in order for me to fix #111.
@WYHNUS If we don't include CountryAlpha2Code
as a foreign key in Universities
table, then how do you link them?
Use Sequelize's association which is already defined in DB but not in use for University ...
I see there are quite a number of columns which were reused from the original Assignment 1 project. Can I check if we intend to use any of the following columns?
city
website
vslinkUrl
fbPageId
countryCode
vsCountryAlpha2Code
logoUrl
vslogoImageUrl
bgImageUrl
emailDomains
terms
topUnisId
We might want to keep the
topUnisId
column if we wish to make use of the data found on topuniversities.com to fetch wiki data or something.