search

WYHNUS / ExchangeBuddy

Find your exchange buddies!
5 stars 0 forks source link

PUT /university accept optional fields #140

Closed irvinlim closed 7 years ago

irvinlim commented 7 years ago

Currently it only accepts name and logoImageUrl, both of which are required parameters. What about other columns like website, city, etc. (as mentioned in #137)?

Also, I think logoImageUrl should not be a required field, but instead countryCode should be?

WYHNUS commented 7 years ago

Good point on countryCode, will fix that tomorrow. :)

irvinlim commented 7 years ago

Ok with you if I just do a quick fix now? Btw for required params, there should be some standardized way to define required parameters for each endpoint right.

WYHNUS commented 7 years ago

Implemented and tested. I suggest we use the same column name for variables in University table.