Implement questions controller

WYHNUS / ExchangeBuddy

Find your exchange buddies!

5 stars 0 forks source link

Implement questions controller #143

Closed unusep closed 7 years ago

irvinlim commented 7 years ago

Would it be better to use

POST /question/:id/vote for upvotes/downvotes
DELETE /question/:id/vote for unvoting (removing up/down votes)

unusep commented 7 years ago

Looks like a good idea. I'll make the changes after camp.

Pros

Looks cleaner
Saves some time and space

Cons

Lose the ability to keep track of what the user has upvoted/downvoted in the past

irvinlim commented 7 years ago

Hmm I see your point. @ZhangHanming do you think it's important to retain that information after someone unvotes? For me, I think not so much.

ZhangHanming commented 7 years ago

@irvinlim unvoting can be done with just simply deleting the entry. Retaining the entry is unnecessary and adds more trouble when the user votes again (need to check if he has voted and whether his previous votes are marked invalid already => more db queries).