WZWren / pe

0 stars 0 forks source link

Several Diagrams not given in standardized pUML format #10

Open WZWren opened 9 months ago

WZWren commented 9 months ago

The format of several diagrams in the DG was not given in the conventional format taught in the CS2103/T textbook.

image.png

image.png

soc-pe-bot commented 9 months ago

Team's Response

Both the diagrams are correct. Diagrams in our DG are completely accurate as per our implementation. It is repeatedly mentioned in the lectures and the tutorials that minor deviations are okay, as long as the intended message is clear. It is a partial class diagram in the DG, therefore, doesn't need to include everything.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While it may be true that the diagrams are accurate, these diagrams are completely off in comparison to what we are taught in class. Note this section from the PE website.

image.png

Compare the given diagrams to the ones in the textbook:

image.png

Additionally, these diagrams are not drawn consistently with the rest of the DG.

image.png

Note that the diagrams are given in the exact same section.

I believe this rejection is rather disingenuous as it is clear that this is not a minor deviation, but rather the team not putting in the care to ensure their formatting is similar to the rest of the document. Observe the difference below when you fail to include the basic styling lines that come with the rest of the DG in AB-3.

image.png

image.png