search

WaLLy3K / wally3k.github.io

Repo for Firebog hosting
https://firebog.net
MIT License
782 stars 39 forks source link

Removed DShield links #111

Closed AndrewDaws closed 4 years ago

AndrewDaws commented 4 years ago

Fixed issue #110

XhmikosR commented 4 years ago

The High list should be recommended and not crossed out IMHO @WaLLy3K. The rest shouldn't be crossed.

EDIT: NVM I should I should have read #110 before posting. EDIT2: The lists shouldn't be crossed out, though, they should be removed.

AndrewDaws commented 4 years ago

EDIT2: The lists shouldn't be crossed out, though, they should be removed.

As I mentioned in issue #110, the post stated they may try to find new input feeds. As to how soon, or how much effort they are putting into actually finding new feeds? I have no idea. But I figured in the short term it might be worth just crossing off for now since they specifically stated they are only suspending the lists, not deprecating them. So I don't know if it's worth removing the lists entirely when they were a very legitimate and good source at one point.

I tried looking for any sort of standard practice for this repo for dealing with this sort of issue, but didn't find any practice that was always followed. In some cases lists were kept, but marked off, to warn people not to use that list that is also found recommended/used elsewhere, meanwhile others were outright removed. So this is definitely a decision for @WaLLy3K for what is the correct course of action.

XhmikosR commented 4 years ago

Yeah, but now they are serving empty content. They should be removed, and if they come back someone should add them again.

WaLLy3K commented 4 years ago

I came into this with the mindset that they should be crossed out (as in "Yes, I acknowledge that I'm aware of these lists but don't recommend them") but since they're suspended and not serving any content, I agree with discussion in this PR and I reckon it's fair to remove them pending those lists serving content again.