WaLLy3K / wally3k.github.io

Repo for Firebog hosting
https://firebog.net
MIT License
763 stars 39 forks source link

EasyList doesn't block ads that it should. #117

Closed ghost closed 4 years ago

ghost commented 4 years ago

First question is, why does the easylist hosted by you differ than the original?

In any case, the ads that are not blocked by pihole are on https://www.startpage.com/

The original Easylist block them through the ?adtype= according to Ublock. Can you please fix, and also what about all the other similar rules?

liamengland1 commented 4 years ago

Do you understand how DNS blocking works?

ghost commented 4 years ago

Yeah, I didn't really look into it much. There's a way to do it with pihole using regex.

liamengland1 commented 4 years ago

Wrong. Pihole cannot block startpage.com/sp/adsense/search/async-ads.js but not https://www.startpage.com/sp/search. You can only block domains, as that's how DNS works.

ghost commented 4 years ago

So what does that mean? Sites are immune from pihole if they run their ads through their own domain?

liamengland1 commented 4 years ago

Basically, that's why you should use uBlock Origin whenever possible for sites like amazon, youtube, etc. that run first-party ads.

ghost commented 4 years ago

Oh well, that's unfortunate. Thanks for the info.

beerisgood commented 4 years ago

Also solutions like PiHole get more and more useless as the sites already move from third party to first party which mean it's not possible with DNS as that would break the whole side.

See that as next step after CNAME which itself is a break for solutions like PiHole and never reach a end.

ghost commented 4 years ago

It's always a cat and mouse game with the big players. For the moment at least, most sites just use external domains and pihole is useful for, I dunno, about 70-80% of the ads, which is good enough when the people on your network don't even know what an ad blocker is.

Although I have noticed quite a bit more false-positives and app/site breaking rules in the default pihole adlists than in default ublock, some of the lists are not that well curated, it seems.

As for the future, I'm guessing pihole will evolve to more than just a DNS blocker, but something that actually inspect the sites like Ublock. But that's just a guess, I don't know their plans.