search

WaLLy3K / wally3k.github.io

Repo for Firebog hosting
https://firebog.net
MIT License
782 stars 39 forks source link

Incorrect domain names #191

Closed Wiggum127 closed 7 months ago

Wiggum127 commented 8 months ago

When parsing your list for a hosts file, I encountered 4 errors of incorrectly formatted domain names:

emam smcom smetriccom smetrics.previcox.d

WaLLy3K commented 8 months ago

Which list is this in, specifically? Thanks!

Wiggum127 commented 8 months ago

Not very clear to me to which of your repo's this applies.

But perhaps this can help. Initially reported the issue elsewhere:

https://github.com/easylist/easylist/issues/18218

And was informed to post the issue here.

WaLLy3K commented 8 months ago

Ah, I see! I'll look into this in the next few days and see why it's not stripping out invalid domains. 🙂

WaLLy3K commented 7 months ago

Oh shoot, I forgot to set a reminder to alert me since something else had came up. My bad!

WaLLy3K commented 7 months ago

Looking over my code, I don't actually perform any domain validation. For some reason, I thought I did. However, I've taken the time to clarify my stance in the readme (in that basically, I don't feel I should be making these kinds of changes and that Pi-hole does it already).

Wiggum127 commented 7 months ago

Having read the statement in the readme, I gather the source of the domains is elsewhere. Can you point me to the right direction to have it solved upstream, please? Thanks.

Wiggum127 commented 6 months ago

@WaLLy3K Can you point me to the right contact to it solved upstream, please ?

AJCxZ0 commented 6 months ago

@Wiggum127 I'm not @WaLLy3K and don't play him in a popular Venezuelan telenovella, however since I've done this before and this case is closed, I'll try to help.

Nowhere in this case did you mention which of the many lists curated by @WaLLy3K contain these entries. If you're updating gravity on a Pi-hole, then you'll see which list contains these in the output, otherwise you'll need to find the list another way. Once you have the URL for the list, view it it your browser. The lists often contain information in comments including contact details for the list owner. What happens after you contact the list owner will of course depend on the list owner.