search

Waavi / translation

Better translation management for Laravel
MIT License
359 stars 167 forks source link

Unnesessary checks #111

Closed michail1982 closed 6 years ago

michail1982 commented 7 years ago

https://github.com/Waavi/translation/blob/master/src/TranslationServiceProvider.php#L76 is query db on each request on pruduction environment. WTF?

andersLAL commented 6 years ago

I agree, this does not seem like a good design. In my case at least, these are pretty slow database queries as well.

I assume it's related to https://github.com/Waavi/translation/issues/104, but there must be a better way to handle that? For example making a note in the documentation that when adding the package to an existing project, use files as the source until migrations are completed? I had the same issue when I started using the package, but just performed the migrations manually, also no big problem.