search

Wabbit0101 / mods_hoardercraft

Wild and wacky ways to hoard ALL the loot (crops, food, materials, gems, etc.) you generate in Minecraft!
GNU General Public License v3.0
11 stars 4 forks source link

[Bug?] Recipe stamps cannot be made for conflicting recipes #52

Open ghost opened 6 years ago

ghost commented 6 years ago

I'm attempting to make mini charcoal automatically, but the recipe conflicts with another. I'm using NoMoreRecipeConflit and it appears in the slot card crafting table, but the table ignores it and only makes instructions for the first recipe.

Wabbit0101 commented 6 years ago

I will have to check if the nomorerecipeconflicts mod has an api I can use. If it doesn't there's not much I can do about the conflict; you'll have to create your own workaround recipe w/ a mod like crafttweaker.

ghost commented 6 years ago

I pulled the conflicting mod anyway, but I thought you should be aware. I should add an issue on GotoLink/RecipeHandler#22, but I'm not exactly sure what to say...

GotoLink commented 6 years ago

To support conflicting recipes, the mod NoMoreRecipeConflict detects your crafting space and result slot, then changes the result slot content per user request: a call is made to Slot#putStack(ItemStack). I think your instruction definition could react to this change by checking both crafting space and result against recipes in the registry.

Wabbit0101 commented 6 years ago

Yeeaa...this table is kindof weird though...it's not really a crafting grid and the "result" is just a preview space that is used for nothing internally; it's the inputs that are stored. This is an known shortcoming of the current implementation(from 1.8) as it assumes the inputs form a unique key to the output -- which can be wrong. Also with the 1.11 jsonification of recipes, it's not really the proper way to go about identifying a recipe (the recipe's registry name should be the primary identifier now).

The mod will need non-trivial rework for 1.13 and I will need a rethink about the instruction table to address recipe-conflicts and oredict ingredients at that time as well.