search

Wabbit0101 / mods_hoardercraft

Wild and wacky ways to hoard ALL the loot (crops, food, materials, gems, etc.) you generate in Minecraft!
GNU General Public License v3.0
11 stars 4 forks source link

[Upsizer] Mushroom stew bug 1.14.4 #86

Closed MelanX closed 4 years ago

MelanX commented 4 years ago

https://gfycat.com/specifichomelyasianwaterbuffalo I think this video says all :) Mod version: 5.0b2

Wabbit0101 commented 4 years ago

Yea...that's Mojang's code for ya. As noted in the mod's overview, items that are normally unstackable aren't always guaranteed to work ok if you consume them from a stack. The problem is the code itself assumes a single-stack and blindly sets the item slot to a bowl when player finishes eating. Interestingly, milk buckets, water bottles and potions are coded properly and work just fine. I will change the default configs to no longer upsize stews by default as upsizer cannot "fix" this without patching SoupItem.

(Self) From all 1.14 SoupItem:

public ItemStack onItemUseFinish(ItemStack stack, World worldIn, LivingEntity entityLiving) {
      super.onItemUseFinish(stack, worldIn, entityLiving);
      return new ItemStack(Items.BOWL);
   }
Wabbit0101 commented 4 years ago

Defaults changed in next beta.