search

Wabbit0101 / mods_hoardercraft

Wild and wacky ways to hoard ALL the loot (crops, food, materials, gems, etc.) you generate in Minecraft!
GNU General Public License v3.0
11 stars 4 forks source link

Bug with Golem Slappers #95

Open PurplePaolo opened 4 years ago

PurplePaolo commented 4 years ago

when i try to take the golem slapper in my inventory the game crashes saying "ticking player" here is the mod list mods.txt

PurplePaolo commented 4 years ago

here is the crash log (with less mod because i removed the less used)

crash.txt

Wabbit0101 commented 4 years ago

Something is messing with enchantments on items. I see the Apotheosis mod in your mod list, it might be something core that mod is tweaking -- what the the max enchantment level for Smite and Knockback in your game?

The issue is your Iron Golem Slappers show an enchantment id of "-1" for Knockback and Smite which is normally what you see when there is an numeric overflow perhaps...the enchantment id is a number that would normally be zero or higher for Minecraft enchantments (never '-1'). The normal values would be Smite = 10 and Knockback = 12. During player idle ticks, PinklySheep does some housekeeping with the weapon enchantments and it tries to find the enchantment associated with -1 which is NULL as there is no such enchantment. Part of your inventory from the crash report:

id:"pinklysheep:golem_slapper_over",Count:1b,tag:{ench:[{lvl:2s,id:-1s},{lvl:2s,id:41s},{lvl:4s,id:-1s}]}

I'll have to confirm it's an issue with how Apotheosis alters the core Enchantment class (it could also be another mod doing the change). If it is I have no idea right now how to workaround that change.

PurplePaolo commented 4 years ago

ok thank you, when i get home i'll try to see what's the max level for those enchantment and i'll try to remove apotheosis and see if the problem still be there

Wabbit0101 commented 4 years ago

The more I think about it the more I wonder if it is Apotheosis at all. Apotheosis tweaks levels not IDs and it's the IDs that seem messed up. Weird one this. I'll have time this weekend to debug this more. One quick test would be to blacklist minecraft:smite and minecraft:knockback in the Apotheosis config and see if the problem goes away.

PurplePaolo commented 4 years ago

i tried playing with only apotheosis and pinkly sheep mods but the game doesnt crash at all so it isnt the problem

PurplePaolo commented 4 years ago

ok i figured out that the problem was the mod "inspirations", i dont know why But removing that mod works and the modpack doesnt crash, with all the other 196 mod i mean