Wabere / garglk

Automatically exported from code.google.com/p/garglk
Other
0 stars 0 forks source link

Making smart quotes slightly smarter #120

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Currently garglk will convert a straight quote mark to a curly left quote if 
the character immediately preceding it is a space; however, there is another 
circumstance where a left-quote is appropriate: left parentheses/brackets.  
This can be seen in e.g. the introduction to "All Quiet on the Library Front" 
(the following paragraph is a quote from that game):

That final paper is due for your Computer Science class ("The History of IF 
Games"), and you desperately need to check out a comprehensive book on Graham 
Nelson, one of the foremost authors of the obscure genre of interactive-fiction.

I've done a quick look through disassemblies of competition and Infocom games, 
and came across perhaps 8-10 games that would benefit from left-quotes after an 
opening parenthesis, and zero that would suffer.  I've attached a patch that 
implements this.  It checks for an opening square bracket, too, which looks 
like it will be beneficial for at least Arthur and Zork Zero.

Original issue reported on code.google.com by cspiegel@gmail.com on 11 Sep 2010 at 7:06

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks! I've applied the patch.

Please let me know if you are interested in commit access to the repository.

Original comment by bcressey@gmail.com on 13 Sep 2010 at 4:28

GoogleCodeExporter commented 8 years ago

Original comment by bcressey@gmail.com on 13 Sep 2010 at 5:02