Waboodoo / HTTP-Shortcuts

Android app to create home screen shortcuts that trigger arbitrary HTTP requests
https://http-shortcuts.rmy.ch
MIT License
1.17k stars 113 forks source link

[BUG] several dialogs disappear on screen rotation #262

Closed davirec closed 1 year ago

davirec commented 2 years ago

When I perform these sequences of events, the dialog disappears on-screen rotation: Steps To Reproduce

  1. Go to the Main activity
  2. Tap in add (plus in the right bottom)
  3. A fragment similar to this will appear:
  1. Force the pause from the activity and then return to the activity (double rotation). Note that the fragment disappears. Note: the pause from activity can be performed in several ways. We suggest using a double rotation (starts in portrait, goes to landscape, and back to portrait) with this function previously enabled in the smartphone.

Expected behavior The expected behavior is the return to the previous state with the fragments of the previous image.

Actual behavior However, the fragment disappears.

This bug occurs in activities:

Device:

Waboodoo commented 2 years ago

Thanks for the bug report. This is basically the same bug as https://github.com/Waboodoo/HTTP-Shortcuts/issues/261. It applies to any dialog window in the app. There is currently a technical limitation around this, and I'll need to do some more refactoring to preserve the state of these dialogs. So, for now, this is "expected" behavior.

davirec commented 2 years ago

Thanks

Waboodoo commented 2 years ago

Most if not all of these should now be addressed. There are still a handful of dialogs that might get lost on a configuration change, so I'll keep this issue open until I'm sure I got them all.

Waboodoo commented 2 years ago

I believe that at this point (as of version 2.18.0), the only dialogs that disappear or lose state when the activity is recreated at the ones created when clicking one of the many "{}" variable insertion buttons in the app. I will try to fix those soon.

davirec commented 2 years ago

Thanks

Waboodoo commented 1 year ago

In version 3.0.0 I overhauled the entire app's UI. I hope that as part of this, I managed to fix this issue for all the dialogs.