Wacky-Mole / WackysDatabase

RecipeCustomization + Server Sync + OpenDatabase + Cloning
MIT License
7 stars 8 forks source link

Some bugs to report #19

Open AlanDrake opened 3 months ago

AlanDrake commented 3 months ago

1. wackydb_save_material is case-sensitive, but it can replace the correct material string with a random prefab one of different casing, like blackmarble to BlackMarble, cryptkey to CryptKey, which are incorrect and fail. This makes it impossible to save certain materials. 2. wackydb_save_material throws a IndexOutOfRangeException when called without arguments

  1. Material sync is not working reliably for cloned mats. I've seen it work once, but in over a dozen attempts to see my custom mats hot-reloaded again I did not succeed. The log says "Material sync detected", and no errors. I tried starting from scratch, but in half dozen tries, I failed to get those mats to hot-reload. The only workaround I found to get that hotreload to show changes realtime is enabling overwrite: true and then use the original mat.
Wacky-Mole commented 3 months ago

Thanks for the Bug report. I'll pass this on to Rexabyte.

AlanDrake commented 3 months ago

I'm adding another two (always about materials):

~~4. Modified mats aren't using the expected nearest neighbour texture filtering (pic: original mat vs cloned mat) wdb-textfiltering~~ May be fixed by PR #22 if good enough

  1. Grausten walls and floor don't apply the material on undamaged pieces, and if damaged material takes precedence over damagedMaterial
Wacky-Mole commented 3 months ago

Merged your small fixes. Thx

AlanDrake commented 3 months ago

I don't know how to fix 3 and 5