search

WadhwaniAI / covid-modelling

Repo for modelling the spread of novel Covid-19
MIT License
5 stars 0 forks source link

Detected vs. undetected params #11

Closed smerugu closed 3 years ago

smerugu commented 4 years ago

https://github.com/WadhwaniAI/covid-modelling/blob/160c4d17da7a77b6b8aeaa8b967b21db30d52429/models/seir/seir_testing.py#L23

Why don't we have these among inputs ? Most of the init code would just be (a) constraint based computations e.g., P_mild, T_recov_mild etc, (b) assignment of param values from inputs for the mandatory ones (c) assignment of default param values for the optional inputs. There is room to clean this up for readability

sansiddh commented 3 years ago

I have cleaned up the init code for all SEIR models and I think the new versions address all these points.