WadhwaniAI / covid-modelling

Repo for modelling the spread of novel Covid-19
MIT License
5 stars 0 forks source link

refactor/clean IHME code #32

Closed vishwa-wai closed 4 years ago

vishwa-wai commented 4 years ago
vishwa-wai commented 4 years ago

some basic docs related improvements are in the works already 😄 and yes - agree on moving configs, but I think figuring out a better way to pass it in will help. reason i put it inside scripts was mostly for ease of passing path in as a command line arg

+1 ideal situation is making models as interchangeable as possible, still a bit more to do to get to that point. I think it will require some mods to SEIR functions as well and didn't want to get into that right now, so left it this way

vishwa-wai commented 4 years ago

and yes - ihme/model contains things that might be better suited for utils/ihme/ - can make that switch