search

WadhwaniAI / covid-modelling

Repo for modelling the spread of novel Covid-19
MIT License
5 stars 0 forks source link

Init inputs #8

Closed smerugu closed 3 years ago

smerugu commented 4 years ago

https://github.com/WadhwaniAI/covid-modelling/blob/160c4d17da7a77b6b8aeaa8b967b21db30d52429/models/seir/seir_testing.py#L11

Note: none of these are critical-must do changes.

1) Not a good idea to include intervention (start,end date, intervention amount) in primary model class code 2) starting date might also not appropriate for the model (init_values will take care of this); you could have this in a wrapper function with real region data hooks
3) Looks like q can't be independently determined since you already have a transition time parameter for D_I- best to skip ( I might have got this wrong - we can discuss) 4) why do we need init_infected separately when you also have state_init_values? 5) Let us discuss the hosp/mild/severe/fatal compartments, transition time choices T_hosp, T_recov_mild, T_recov_severe, T_fatal and interpretation for a future version.

sansiddh commented 3 years ago

Closing old issues. All 5 of these have been addressed in the new SEIR classes.