search

Wafelowski / grav-theme-darkquark

MIT License
9 stars 1 forks source link

Crash when setting a custom logo #8

Open simplylu opened 1 year ago

simplylu commented 1 year ago

When setting a custom logo and save, all changes will be saved but the logo. Seems like grav / your theme is not allowed to write to user/themes/darkquark/images/logo.

Managed to solve it by exec'ing into the docker container and execute: chmod ugo+rwx user/themes/darkquark/images/logo (since I don't know the exact user).

Retrying to upload the image works. Maybe switching back to the old rights would be suitable then. Any possibilities on your side to fix this?

Grav Version:

/var/www/grav # ./bin/gpm selfupgrade

GPM Releases Configuration: Stable

You are already running the latest version of Grav v1.7.37.1
which was released on Wed Oct  5 21:06:41 2022

Docker version:

user@host:~/Docker$ docker --version
Docker version 20.10.21, build baeda1f

Container used for deploying Grav: grav-daddy

KGOrphanides commented 1 year ago

Unsurprisingly, the same version deployed manually suffers the same issue as when deployed with Docker. However, the described fix didn't work for me - the files can be uploaded on a page reload, but are not displayed (this may be an unrelated image formatting issue, however).

Wafelowski commented 1 year ago

That's interesting, it seems that something broke within the last couple versions of Grav, as my outdated one works. I don't use Docker, my knowledge is minimal about it, but I will try my best to reproduce the issue. I'm wondering if even the theme can be responsible for setting file permissions.