Refactor the middleware and allow thread safety.

Wafris / wafris-rb

Wafris Client for Rails and Rack applications

https://wafris.org

Other

90 stars 7 forks source link

Refactor the middleware and allow thread safety. #67

Closed ruyrocha closed 9 months ago

ruyrocha commented 9 months ago

Closing in favor of major upcoming refactor.

rmcastil commented 9 months ago

@ruyrocha thanks for all the PRs. Sorry that I haven't responded sooner. I've been handling a major upgrade to Hub. What upcoming refactor do you have in mind?

ruyrocha commented 8 months ago

@rmcastil there are a few items to cover:

it seems that the middleware is sharing too much state
Hiredis can be used instead of the Ruby driver
the logger is confusing
there is no need to pass the whole request object for self.allow_request?
I'm in doubt about calling dup on the call method due to the way the Redis connection is defined