search

Wafris / wafris-rb

Wafris Client for Rails and Rack applications
https://wafris.org
Other
90 stars 7 forks source link

Dup all request strings in middleware #81

Closed baueric closed 2 days ago

baueric commented 2 weeks ago

Frozen strings cause errors when being mutated

https://github.com/Wafris/wafris-rb/issues/80

rmcastil commented 2 weeks ago

@baueric thanks for opening up the PR! So the errors you encountered are due to forcing encoding on frozen strings on the request object? And your solution is to create duplicates prior to forcing the encoding?

baueric commented 1 week ago

Correct, and it's better that the Wafris middleware does not have side-effects on the request object data.

baueric commented 6 days ago

@rmcastil any update on this?

rmcastil commented 6 days ago

Hey Eric,

We have a number of bug fixes that we're trying to release with this. I'm also adding tests around the middleware class in general.

Should have it merged in and a release cut in the next couple of days.

I'll make sure you get credit in the README. Thanks for the PR!

On September 12, 2024, GitHub @.***> wrote:

@rmcastil https://github.com/rmcastil any update on this?

— Reply to this email directly, view it on GitHub https://github.com/Wafris/wafris-rb/pull/81#issuecomment-2345271374, or unsubscribe https://github.com/notifications/unsubscribe- auth/AABF6M5SSMJN2FM3EXPMHZ3ZWENEBAVCNFSM6AAAAABNTTJY22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGI3TCMZXGQ. You are receiving this because you were mentioned.Message ID: @.***>

rmcastil commented 2 days ago

@baueric merged this in this morning. Thanks for your contribution!