Wag-Media / wagmedia-com-bot

Wagmedia Communications Bot
0 stars 0 forks source link

Do not handle rules for external Discord Server emojis #42

Closed niklasp closed 8 months ago

niklasp commented 8 months ago

only wagmedia specific emojis should trigger rules. all others should just be recorded.

niklasp commented 8 months ago

@ikhaled28 i checked the bot code and am 90% sure it does not process external emojis (e.g. an "50WMUSD" emoji from another server would be recorded but not trigger a payment). Is this the desired behavior or should something else happen?

ikhaled28 commented 8 months ago

Yes it is related to Payment emojis. So to be more clear, do not record anything which contains the same name like our Payment emojis. Rest can be ok. If those payment emojis comes from external server just remove those, as It might gives scammer a chance for fraud claims.

niklasp commented 8 months ago

hmm. i cannot remove only "payment emojis" from external servers, anyone can name their emojis how they wish and use our images for it. what i can do is disallow all external emojis on monitored channels? or just dont do anything.

I mean it is misleading to see some payment emojis looking the same but as they will trigger no payment it doesnt matter? just confuse

ikhaled28 commented 8 months ago

hmm. i cannot remove only "payment emojis" from external servers, anyone can name their emojis how they wish and use our images for it. what i can do is disallow all external emojis on monitored channels? or just dont do anything.

I mean it is misleading to see some payment emojis looking the same but as they will trigger no payment it doesnt matter? just confuse

yeah you are right. Can we just not read the same name then. Like if we see an external emoji named same like our server one then we can ignore it anyway, that will do for us.

niklasp commented 8 months ago

hmm i dont know what to do here really. i suggest not tracking external emojis at all?

ikhaled28 commented 8 months ago

Yeah, ignore the issue. Close the issue for now