Removed almost all duplicated primitives fixed life gain loop adding new keyword "except", added PCA/W17/DDR sets and merged the PSP graphic Folder with PC/Android one

WagicProject / wagic

Wagic the Homebrew

Other

354 stars 81 forks source link

Removed almost all duplicated primitives fixed life gain loop adding new keyword "except", added PCA/W17/DDR sets and merged the PSP graphic Folder with PC/Android one #1026

Closed Vitty85 closed 5 years ago

Vitty85 commented 5 years ago

Still some duplicated primitives stays between unsupported and borderline/crappy (they were already duplicated in the old master).

coveralls commented 5 years ago

Coverage decreased (-40.6%) to 0.0% when pulling 744e380df9da2e6fcb88bfe1b91e42f6e4d7f51a on Vitty85:master into 87ce6df145b1d09af8e3a979d15236e9d920ed00 on WagicProject:master.

Vitty85 commented 5 years ago

I added the PCA set and fixed one primitive in MH1 set too, i guess we can merge with master.

Vitty85 commented 5 years ago

Fixed Angel of Vitality in M20 set and added new keyword "except" for @lifeof trigger in order to avoid a life gain loop when a card needs to increment life gaining in that phase (eg. Angel of Vitality).

xawotihs commented 5 years ago

Please add testcases as well if you add key words

Vitty85 commented 5 years ago

I tested with Angel of Vitality primitives and with other life gain cards, just i didn't add a specific txt file for test. I will try to do ASAP.

Vitty85 commented 5 years ago

Please add testcases as well if you add key words

I added 3 new tests and also all the other tests have been successfully passed too.

Vitty85 commented 5 years ago

I removed the graphic_psp directory i previously added so now there is just only one graphic folder as it should be. Images for PSP are separated from PC/Android one with prefix psp and they are correctly loaded in C++ file with ifdef PSP (as already done for several other situations).

Vitty85 commented 5 years ago

Great,

If we are planning to make an official Wagic release I will modify the java main class of android app in order to refer the core file and the csv database in the official GitHub repo and not from my repo.

Let me know, see you!

-- Inviato da iPhone

Il giorno 12 set 2019, alle ore 13:33, Xawotihs notifications@github.com ha scritto:

Merged #1026 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

xawotihs commented 5 years ago

If you're interested, I can add you to the Wagic project. Currently, I don't have the time to do much more than fixing the CI.

Vitty85 commented 5 years ago

For me it’s ok, you can add me and I can prepare a new official release.

Do you think we can call it 0.21.2 or 0.22.1?

Let me know when you are done, see you!

-- Inviato da iPhone

Il giorno 12 set 2019, alle ore 14:08, Xawotihs notifications@github.com ha scritto:

If you're interested, I can add you to the Wagic project. Currently, I don't have the time to do much more than fixing the CI.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Vitty85 commented 5 years ago

I received your invite and I joined wagic project.

Thanks, see you soon.

-- Inviato da iPhone

Il giorno 12 set 2019, alle ore 14:08, Xawotihs notifications@github.com ha scritto:

If you're interested, I can add you to the Wagic project. Currently, I don't have the time to do much more than fixing the CI.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.