Closed erzvtvhfm-fhjnyfxv closed 3 years ago
With this week's PR I have two questions:
...
if (scryset.equalsIgnoreCase("MRQ"))
scryset = "MMQ";
else if (scryset.equalsIgnoreCase("AVN"))
scryset = "DDH";
else if (scryset.equalsIgnoreCase("BVC"))
scryset = "DDQ";
else if (scryset.equalsIgnoreCase("CFX"))
scryset = "CON";
else if (scryset.equalsIgnoreCase("DM"))
scryset = "DKM";
else if (scryset.equalsIgnoreCase("EVK"))
scryset = "DDO";
else if (scryset.equalsIgnoreCase("EVT"))
scryset = "DDF";
else if (scryset.equalsIgnoreCase("FVD"))
scryset = "DRB";
else if (scryset.equalsIgnoreCase("FVE"))
...
where does this difference come from? (For CON it's quite obvious - https://superuser.com/questions/86999/why-cant-i-name-a-folder-or-file-con-in-windows - but for others not so).
Hi,
I have some commits to do too, i will merge your pull soon.
About your 2 questions:
1) If you are using Linux (e.g. Ubuntu), you can compile with qt and using a special flag to create an exe for running test suites: $QMAKE projects/mtg/wagic-qt.pro CONFIG+=console CONFIG+=debug DEFINES+=CAPTURE_STDERR make -j 4
Generally whatever you need to create the compile env is descibed in .travis.xml file, while all the step for compiling are listed in the tools/travis-script.sh file, you can take a look there.
2) About names i don't know the story, i entered the project when those names were already there, so i just made my downloader able to "translate" those name into Scryfall names in order to download the corrected images, that's all.
See you.
Initially committed in 89dae6523 (Nov 3, 2008) and 202d46176 (Sep 22, 2009).
Major changes done only in deck3:
Also deck34 (Kobolds) was kept with original frames because Kobolds were never reprinted.