WagicProject / wagic

Wagic the Homebrew
Other
347 stars 76 forks source link

Add Dominaria United (DMU) to sets/ #1082

Closed fechmistrz closed 1 year ago

fechmistrz commented 1 year ago

Hi! I would like to contribute to Wagic with coding. Not sure what are rules in this project, please send me some guidelines if there are any. Are you using https://wololo.net/forum/, Discord or anything similar to cooperate?

Later I can send merge requests for other recent sets, both _cards.dat and primitives (unless somebody else is doing this right now, no need to waste time doing the same thing).

coveralls commented 1 year ago

Coverage Status

Coverage increased (+0.002%) to 38.494% when pulling 7fa116864c95dd5f6de19d275a2a8079f770a662 on fechmistrz:new-set/dmu into bada76ec857177d961501adf7ae1fd3aae878e8e on WagicProject:master.

EduardoMunozGomez commented 1 year ago

Hi, welcome, sadly https://wololo.net/forum/ its kinda abandoned and full of spam bots but it is the official channel for communication, I guess we could use that or direclty in Github.

The most I need help is with the primitives of the sets released this year. I Have some simple Neo Kamigawa ones and I generate the backbone of new sets programmatically so the characteristics of the cards are present, this avoids errors, typos and I just have to focus on the effect and no other part of the card. Example: (https://wololo.net/forum/viewtopic.php?f=22&t=67924 )

The cards in mtg.txt are mostly before Kaladesh and borderline.txt after, most developers moved on around this era so that's why it was labeled as that, but it really doesn't mean anything, most cards end up in borderline.txt and now is around the same size than mtg.txt. I would even like a name change for the borderline.txt file name.

No idea about naming convention for sets, they do not have an official source and serve the purpose to "filter by sector" inside the application.

BobCyril commented 1 year ago

One idea might be to PM Wololo at wololo.net/forum and ask for admin powers for the project message board. An appeal for others to help with moderation might also help control the spammers. In an extreme case, even if the board became read-only for everyone but devs and testers it would be a good way to show that development continues.

Antaritic commented 1 year ago

 您好!邮件已收到,我将尽快回复。

此致       祝好