search

WahlNetwork / vester

Easily validate and remediate your vSphere configuration
https://wahlnetwork.com
Apache License 2.0
146 stars 45 forks source link

Adding a top level entry and four tests for datastore clusters. #112

Closed midacts closed 7 years ago

jonneedham commented 7 years ago

Hey midacts, awesome job on this! I left a few comments in the files themselves. One thing I did want to ask about was the file naming scheme. DSC is short Datastore Cluster and Desired State Configuration, so using that in the file names may be a little confusing. Do you think it may make more sense just to pull that bit off, since the files themselves are in the DSCluster folder? Also, for the DRS test, should it be called SDRS-AutomationLevel.Vester.ps1? Just a thought.

For now I just looked at the code. It looks straight forward and like it will work, but I'll try to get it downloaded / tested as well. Thanks for submitting this!

midacts commented 7 years ago

Good catch. I had been testing with clusters and knew I couldn't do $cluster | get-datastorecluster.

I can modify and test the code and then go from there.

Thanks for the review.

midacts commented 7 years ago

the file naming scheme. DSC is short Datastore Cluster and Desired State Configuration That is an excellent point. I didn't really like naming it like that either. I'll make those modifications.

Also, I really don't like the 'DScluster', but 'DatastoreCluster' seemed too long and was going to cause me to have to do more formatting to the file. Should we keep it 'DScluster' or go with 'DatastoreCluster'?

brianbunke commented 7 years ago

I'm fine with DSCluster. s/o to @jonneedham for the initial review.

:shipit: