search

WahlNetwork / vester

Easily validate and remediate your vSphere configuration
https://wahlnetwork.com
Apache License 2.0
146 stars 45 forks source link

Referencing $cfg inside Test Files #131

Open midacts opened 7 years ago

midacts commented 7 years ago

This is more of a FYI and making sure that this is the best way to handle it.

Currently $Desired = $cfg.... is the only time $cfg is allowed to be referenced in a test files do to these lines (specifically the lines referencing $Cfgline). (and it then being passed to Set-VesterConfigValue.ps1)

I was able to work around this in Test Files by doing things like this:

$Save = Get-ChildItem Variable: | Where-Object {$_.Value -Match "host"}
$DCUIAccess = $Save.Value.Host.dcuiaccess

Are you guys okay with using the above types of references in test files? I think it is easier than refactoring parts of New-VesterConfig.ps1

michaeltlombardi commented 7 years ago

Should this be a documentation issue where we add a concept document for how this works / help people understand if this is an anti-pattern or not and considerations to be taken when doing it?

midacts commented 7 years ago

Whatever works. I was just bringing up things I was running into when i was digging more into issues.

Basically it is referencing variables from the config file in other test files.