search

WahlNetwork / vester

Easily validate and remediate your vSphere configuration
https://wahlnetwork.com
Apache License 2.0
146 stars 45 forks source link

Hotfix/config gen #188

Closed NamedJason closed 6 years ago

NamedJason commented 6 years ago

I changed the regex to be more discriminating when looking for the $cfg line, so that it will be more likely to find the correct line from each test and thus be able to determine where to store that test's results in the generated config file.

brianbunke commented 6 years ago

Hey! Thanks for following up on your last PR with this.

I've been tracking this in #178, and ended up working on it over the weekend. I just got to submitting #191 to use the AST instead of RegEx, which should achieve the same goal.

I try to assign open issues where I can, because I feel really bad when we spend our free time duplicating work. Sorry! 🙁

NamedJason commented 6 years ago

No worries - I saw that it was assigned to you before I started on this. I just wanted to put together something quick to allow me to test a new version of the host vds membership test, so figured that I'd do the quick fix and just change the regex while you worked on a real solution. Most of the time that I spent on it was just familiarizing myself with how the various pieces of vester fit together, which was time well spent even though this commit was obviated. I've never even heard of AST before, so this is a great learning experience for me in several ways!

brianbunke commented 6 years ago

Awesome, glad to hear that.