WahlNetwork / vester

Easily validate and remediate your vSphere configuration
https://wahlnetwork.com
Apache License 2.0
146 stars 45 forks source link

Standalone Hosts... #212

Open rockaut opened 6 years ago

rockaut commented 6 years ago

Currently no "standalone" hosts can't be scanned as in "VesterTemplate.Tests.ps1" around line 41 there is 'Host' {$Datacenter | Get-Cluster -Name $cfg.scope.cluster | Get-VMHost -Name $cfg.scope.host}

Expected Behavior

Also scan standalone hosts any way provided - in devinitive scope or with wildcard.

Current Behavior

Completely ignores any host outside clusters

Possible Solution

I tried to just remove Get-Cluster -Name $cfg.scope.cluster | but than you can't filter on just on cluster as all hosts are returned.

rockaut commented 6 years ago

I came up with that:

'Host' { if( $cfg.scope.cluster -ne "*" -and $cfg.scope.host -eq "*" ) { $Datacenter | Get-Cluster -Name $cfg.scope.cluster | Get-VMHost -Name $cfg.scope.host } elseif( $cfg.scope.cluster -ne "*" -and $cfg.scope.host -ne "*" ) { $Datacenter | Get-Cluster -Name $cfg.scope.cluster | Get-VMHost -Name $cfg.scope.host } else { $Datacenter | Get-VMHost -Name $cfg.scope.host } }

I may provide an PR but first wanted to see communities thoughts.