Unable to change NGramTokenizerFactory properties (GUI)

Waikato / wekaDeeplearning4j

Weka package for the Deeplearning4j java library

https://deeplearning.cms.waikato.ac.nz/

GNU General Public License v3.0

184 stars 197 forks source link

Unable to change NGramTokenizerFactory properties (GUI) #66

Closed fdebeyan closed 3 years ago

fdebeyan commented 3 years ago

Description

In DJ4LStringToWordVec, using NGramTokenizerFactory, when I click on properties and change NMax, NMin or delimiters and click on OK, the properties are not changed.

Expected behavior:

Properties (NMax, NMin, Delimiters) are changed.

Encountered behavior:

Properties (NMax, NMin, Delimiters) revert to default values.

Additional Information

Weka version: 3.8.5
wekaDeeplearning4j package version: 1.7.1
Operating System: Mac and Linux.

basedrhys commented 3 years ago

Thanks for finding this - will look into it.

basedrhys commented 3 years ago

Have fixed this issue - will be included in the next WDL4J minor release (coming soon)