search

Waitsnake / AnimatedGif

A screensaver for Mac OSX / macOS that plays animated GIFs and APNGs
MIT License
213 stars 31 forks source link

Multiple Change Timers in Preview Mode #48

Closed Waitsnake closed 5 years ago

Waitsnake commented 5 years ago

In Preview Mode within the screensaver options and when the config panel is closed an stopAnimation event is fired by ScreenSaverFramework and then an startAnimation event. startAnimation starts a new change timer, but the old timer was not stopped and so multiple change timer could be running. With multiple open and closing of the config panel this could lead to a very high number of running timers and very short and unpredictable change intervals of the preview form the screensaver. Once I even see [MTKView currentDrawable] crashing due to the high frequency.

This never happen in Normal or Background Mode since in those modes the stopAnimation event is only send before screensaver process closes completely and this will end also a running timer.

Waitsnake commented 5 years ago

Fixed with last commit.

Since this very rarely happen it is no urgent reason for a next release and so the next release comes when there are more fixes or advancements in it.